mirror of
https://github.com/NixOS/nixpkgs.git
synced 2026-03-08 01:24:09 +01:00
The footer has the following problems: - It's not consistently added in all PRs, for example backports or those where the template is not used. Inconsistency in a voting skews the results. - It's arguably not effective, because people use reactions naturally to interact with PRs anyway. As long as there are multiple different reaction types, what does it mean that one PR has 20 👍, but another has 22 🎉? The latter won't show up in the ranking for 👍, so at the minimum confusing. Same for ❤️. - It's not useful to determine priority as in "higher number of votes should be merged". A PR's quality should be determined independently of votes - when it's good, it will be merged. The currently most upvoted PR has serious issues, so this invites drive-by questions like "Why isn't this merged, given the number of upvotes?".
1.9 KiB
1.9 KiB
Things done
- Built on platform:
- x86_64-linux
- aarch64-linux
- x86_64-darwin
- aarch64-darwin
- Tested, as applicable:
- NixOS tests in nixos/tests.
- Package tests at
passthru.tests. - Tests in lib/tests or pkgs/test for functions and "core" functionality.
- Ran
nixpkgs-reviewon this PR. See nixpkgs-review usage. - Tested basic functionality of all binary files, usually in
./result/bin/. - Nixpkgs Release Notes
- Package update: when the change is major or breaking.
- NixOS Release Notes
- Module addition: when adding a new NixOS module.
- Module update: when the change is significant.
- Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.