archives/zig
1
0
Fork 0
mirror of https://codeberg.org/ziglang/zig.git synced 2026-03-08 04:24:33 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

std.fs: fix test cases regarding error.IsDir on WASI

Browse source 
why were we testing for shitty behavior?
This commit is contained in:
Andrew Kelley 2026-01-14 20:48:01 -08:00
parent e70def70ec
commit c4df980ac2
1 changed files with 2 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

13
lib/std/fs/test.zig
View file

@ -827,11 +827,6 @@ test "file operations on directories" {
const buf = try ctx.dir.readFileAlloc(io, test_dir_name, testing.allocator, .unlimited);
testing.allocator.free(buf);
},
.wasi => {
// WASI return EBADF, which gets mapped to NotOpenForReading.
// See https://github.com/bytecodealliance/wasmtime/issues/1935
try expectError(error.NotOpenForReading, ctx.dir.readFileAlloc(io, test_dir_name, testing.allocator, .unlimited));
},
else => {
try expectError(error.IsDir, ctx.dir.readFileAlloc(io, test_dir_name, testing.allocator, .unlimited));
},
@ -851,13 +846,9 @@ test "file operations on directories" {
defer handle.close(io);
// Reading from the handle should fail
const expected_err = switch (native_os) {
.wasi => error.NotOpenForReading,
else => error.IsDir,
};
var buf: [1]u8 = undefined;
try expectError(expected_err, handle.readStreaming(io, &.{&buf}));
try expectError(expected_err, handle.readPositional(io, &.{&buf}, 0));
try expectError(error.IsDir, handle.readStreaming(io, &.{&buf}));
try expectError(error.IsDir, handle.readPositional(io, &.{&buf}, 0));
}
try expectError(error.IsDir, ctx.dir.openFile(io, test_dir_name, .{ .allow_directory = false, .mode = .read_only }));