archives/zig
1
0
Fork 0
mirror of https://codeberg.org/ziglang/zig.git synced 2026-03-08 02:24:33 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

std: re-enable some disabled tests

Browse source 
I believe these tests may have been flaky as a result of the bug fixed
in the previous commit. A big hint is that they were all crashing with
SIGSEGV with no stack trace. I suspect that some lingering SIGIOs from
cancelations were being delivered to a thread after its `munmap` call,
which was happening because the test runner called `Io.Threaded.deinit`
to cause all of the (detached) worker threads to exit.

If this passes, I'll re-run the x86_64-linux CI jobs on this commit a
few times before merge to try and be sure there are no lingering
failures.

Resolves: https://codeberg.org/ziglang/zig/issues/30096
Resolves: https://codeberg.org/ziglang/zig/issues/30592
Resolves: https://codeberg.org/ziglang/zig/issues/30682
This commit is contained in:
Matthew Lugg 2026-01-06 11:13:13 +00:00
parent 073ef0f393
commit be0a77efd2
No known key found for this signature in database
GPG key ID: 3F5B7DCCBF4AF02E
2 changed files with 0 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

4
lib/std/Io/test.zig
View file

@ -254,8 +254,6 @@ test "Group.cancel" {
}
test "Group.concurrent" {
if (builtin.os.tag == .linux and !builtin.link_libc) return error.SkipZigTest; // https://codeberg.org/ziglang/zig/issues/30096
const io = testing.io;
var group: Io.Group = .init;
@ -421,8 +419,6 @@ test "Event" {
}
test "recancel" {
if (builtin.os.tag == .linux and !builtin.link_libc) return error.SkipZigTest; // https://codeberg.org/ziglang/zig/issues/30592
const global = struct {
fn worker(io: Io) Io.Cancelable!void {
var dummy_event: Io.Event = .unset;

2
lib/std/crypto/argon2.zig
View file

@ -907,8 +907,6 @@ test "kdf" {
}
test "phc format hasher" {
if (true) return error.SkipZigTest; // https://codeberg.org/ziglang/zig/issues/30682
const allocator = std.testing.allocator;
const password = "testpass";
const io = std.testing.io;