archives/zig
1
0
Fork 0
mirror of https://codeberg.org/ziglang/zig.git synced 2026-03-08 02:44:43 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Fixes enums.fromInt failing at compile time on in range but invalid values

Browse source
This commit is contained in:
Mason Remaley 2025-12-08 17:24:17 -08:00 • committed by Alex Rønne Petersen
parent b346090ed2
commit 3af842f0e8
1 changed files with 6 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

7
lib/std/enums.zig
View file

@ -22,7 +22,7 @@ pub fn fromInt(comptime E: type, integer: anytype) ?E {
// without requiring an inline loop.
// This generates better machine code.
for (values(E)) |value| {
if (@intFromEnum(value) == integer) return @enumFromInt(integer);
if (@intFromEnum(value) == integer) return value;
}
return null;
}
@ -213,6 +213,7 @@ test fromInt {
B,
};
const E3 = enum(i8) { A, _ };
const E4 = enum(u8) { A };
var zero: u8 = 0;
var one: u16 = 1;
@ -226,6 +227,10 @@ test fromInt {
try testing.expectEqual(null, fromInt(E1, one));
try testing.expectEqual(null, fromInt(E3, 128));
try testing.expectEqual(null, fromInt(E3, -129));
// `fromInt` used to produce a compiler error instead of `null` if trying to convert an integer
// that wasn't out of range, but also wasn't a valid value.
try testing.expectEqual(null, fromInt(E4, 1));
}
/// A set of enum elements, backed by a bitfield. If the enum