archives/zig
1
0
Fork 0
mirror of https://codeberg.org/ziglang/zig.git synced 2026-03-08 02:44:43 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

std.Io.Threaded: don't skip executing canceled group closures

Browse source
This commit is contained in:
Andrew Kelley 2025-10-27 14:08:51 -07:00
parent df4c30ca16
commit 0caf286a1a
1 changed files with 2 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

6
lib/std/Io/Threaded.zig
View file

@ -566,10 +566,8 @@ const GroupClosure = struct {
const reset_event: *ResetEvent = @ptrCast(&group.context);
if (@cmpxchgStrong(CancelId, &closure.cancel_tid, .none, tid, .acq_rel, .acquire)) |cancel_tid| {
assert(cancel_tid == .canceling);
// We already know the task is canceled before running the callback. Since all closures
// in a Group have void return type, we can return early.
syncFinish(group_state, reset_event);
return;
// Even though we already know the task is canceled, we must still
// run the closure in case there are side effects.
}
current_closure = closure;
gc.func(group, gc.contextPointer());