This commit was created by a combination of scripts and tools:
- an ast-grep script to prefix things in meta with `lib.`,
- a modified nixf-diagnose / nixf combination to remove unused `with
lib;`, and
- regular nixfmt.
Co-authored-by: Wolfgang Walther <walther@technowledgy.de>
This reverts commit 65a333600d.
This wasn't tested for correctness with something like fodwatch [0],
and should not have been (self-)merged so quickly, especially without
further review.
It also resulted in the breakage of at least one package [1] (and that's
the one we know of and was caught).
A few packages that were updated in between this commit and this revert
were not reverted back to using `rev`, but other than that, this is a
1:1 revert.
[0]: https://codeberg.org/raphaelr/fodwatch
[1]: https://github.com/NixOS/nixpkgs/pull/396904 / 758551e458
After final improvements to the official formatter implementation,
this commit now performs the first treewide reformat of Nix files using it.
This is part of the implementation of RFC 166.
Only "inactive" files are reformatted, meaning only files that
aren't being touched by any PR with activity in the past 2 months.
This is to avoid conflicts for PRs that might soon be merged.
Later we can do a full treewide reformat to get the rest,
which should not cause as many conflicts.
A CI check has already been running for some time to ensure that new and
already-formatted files are formatted, so the files being reformatted here
should also stay formatted.
This commit was automatically created and can be verified using
nix-build https://github.com/infinisil/treewide-nixpkgs-reformat-script/archive/a08b3a4d199c6124ac5b36a889d9099b4383463f.tar.gz \
--argstr baseRev b32a094368
result/bin/apply-formatting $NIXPKGS_PATH
checkInputs used to be added to nativeBuildInputs. Now we have
nativeCheckInputs to do that instead. Doing this treewide change allows
to keep hashes identical to before the introduction of
nativeCheckInputs.
continuation of #109595
pkgconfig was aliased in 2018, however, it remained in
all-packages.nix due to its wide usage. This cleans
up the remaining references to pkgs.pkgsconfig and
moves the entry to aliases.nix.
python3Packages.pkgconfig remained unchanged because
it's the canonical name of the upstream package
on pypi.
This reverts commit fb6d63f3fd.
I really hope this finally fixes#99236: evaluation on Hydra.
This time I really did check basically the same commit on Hydra:
https://hydra.nixos.org/eval/1618011
Right now I don't have energy to find what exactly is wrong in the
commit, and it doesn't seem important in comparison to nixos-unstable
channel being stuck on a commit over one week old.
https://github.com/iputils/iputils/releases/tag/s20190709
See release notes for details,
but of particular note is that
this expression is now quite simpler
due to the following:
* ninfod now builds w/nettle!
* update includes patches we fetched from upstream
* cross should be handled now, during move to meson
* prelim testing confirms, meson makes it much easier
to get things right re:explanation given in comment
(not propagating host/target info)
* issue re:musl+idn2 appears resolved re:compilation,
but results in unclear runtime errors regarding
"invalid flags". Keep disabled as before as this
is clearer at the expression level and reports
failure to resolve instead which is a bit clearer.
(testing with systemd-less iputils)
This also means our iputils is openssl-free,
which if nothing else is a nice reduction in trans. size :).
(quick imperfect comparison shows:
39MB -> 35MB w/glibc
11.4 -> 7.9 w/musl
)
iputils: nvm no IDN w/musl
iputils: nvm keep idn disabled w/musl
Important changes:
- Two files where removed in [0]:
- bin/ipg
- share/man/man8/pg3.8.gz
- The build system changed from Autotools to Meson.
- New: systemd units and Japanese translations
- "It is probable that within in many many changes a regression may have
slipped in" [1]
[0]: 45a1d39b0c
[1]: https://github.com/iputils/iputils/releases/tag/s20190324
Co-authored-by: Will Dietz <github@wdtz.org>
I *want* cross-specific overrides to be verbose, so I rather not have
this shorthand. This makes the syntactic overhead more proportional to
the maintainence cost. Hopefully this pushes people towards fewer
conditionals and more abstractions.
This makes the command ‘nix-env -qa -f. --arg config '{skipAliases =
true;}'’ work in Nixpkgs.
Misc...
- qtikz: use libsForQt5.callPackage
This ensures we get the right poppler.
- rewrites:
docbook5_xsl -> docbook_xsl_ns
docbook_xml_xslt -> docbook_xsl
diffpdf: fixup
