Commit graph

22 commits

Author SHA1 Message Date
Ben Siraphob
c7e10647ea
treewide: fix typos 2026-01-13 14:45:11 -05:00
Wolfgang Walther
4664ae4470
pkgs/by-name/README: explicitly suggest version specific override interfaces
The current advice of "keeping the override interface" is actively bad,
because it hides certain expectations of a package function in an
undiscoverable place. Ideally, all information about a package is in
one, single place instead.

Version-specific argument names, if required, also have the *benefit* of
creating errors with downstream overrides, much like merge conflicts do.
Instead of possibly silently breaking certain behavior, they make a
change in expectations clear - which might feel annoying when upgrading,
but is ultimately much less problematic down the road.
2025-09-19 21:07:06 +02:00
Ben Siraphob
2f77d9aa7c
pkgs: fix README typos 2025-08-27 11:46:28 -07:00
Wolfgang Walther
62fe016519
treewide: run treefmt with mdcr/nixfmt 2025-07-24 13:52:31 +02:00
Wolfgang Walther
6c47e7d5da
treewide: fix syntax errors in nix code blocks
Fixes all code blocks with "nix" language in markdown files for syntax
errors to be able to run nixfmt in the next step.
2025-07-24 13:52:29 +02:00
Yves Fischer
d56aed834e
pkgs/by-name/README: remove irrelevant link to workflow 2025-06-27 06:28:23 +00:00
Silvan Mosberger
b72bbe662b docs: Fix some links
Discovered with xrefcheck
2025-02-13 21:14:28 +01:00
Doron Behar
52b55691c1 doc/by-name: explain better callPackage and xWithY=x.override transition 2024-09-30 11:56:51 +03:00
Doron Behar
3a0d864123 doc/by-name: explain motivation for transition when custom args are used 2024-09-30 11:56:51 +03:00
aleksana
8ef21e88b6 pkgs/by-name/README.md: use more precise wording on package name
Co-authored-by: Valentin Gagarin <valentin.gagarin@tweag.io>
2024-09-12 08:11:03 +02:00
Silvan Mosberger
0a8a86723e pkgs/by-name: Update manual migration guidelines
Since this original guideline has been written, the new
nixpkgs-merge-bot has appeared, and depends on packages being in
`pkgs/by-name`. It's totally fine to move packages for that purpose
only.

Also update the guidelines to indicate that it might take some time
still for the automated migration to be completed.
2024-09-07 03:59:47 +02:00
Philip Taron
89cbfde96d
nixpkgs-vet: update CI, docs, and release to 0.1.4
Everything gets moved into the `ci/` top-level directory.

We keep behind `maintainers/scripts/check-by-name.sh` and `pkgs/test/check-by-name/pinned-version.txt` as they are going to cause CI errors and confusion until we get all the way through the various channels.
They'll be removed in about a week or so.
2024-09-03 13:53:25 -07:00
Janne Heß
fcc95ff817 treewide: Fix all Nix ASTs in all markdown files
This allows for correct highlighting and maybe future automatic
formatting. The AST was verified to work with nixfmt only.
2024-03-28 09:28:12 +01:00
Silvan Mosberger
f7ea336cb2 workflows/check-by-name.yml: Switch to new separate repo
The nixpkgs-check-by-name tooling is [being moved](https://github.com/NixOS/nixpkgs/issues/286559#issuecomment-2000466124)
to a [separate repo](https://github.com/NixOS/nixpkgs-check-by-name).

This commit updates Nixpkgs CI to use it instead of the tree inside
Nixpkgs

No changes have been made to the tooling locally since it was moved:
- [Exported history](https://github.com/NixOS/nixpkgs/commits/55bf02190ee57fcf83490fd7b6bf7834e28c9c86/pkgs/test/nixpkgs-check-by-name)
- [Imported history](https://github.com/NixOS/nixpkgs-check-by-name/commits/d579e1821d56c79fd90dab34b991cc7bdab7a5c6/)
2024-03-26 21:24:48 +01:00
Silvan Mosberger
8032bb6173 pkgs/by-name: recommendations for multi-versioned packages
Over the past weeks, we've seen one oversight with the new
enforcement of `pkgs/by-name` for new packages.

This documents the problem and the recommendation for resolving it.
2024-03-01 02:58:04 +01:00
Silvan Mosberger
57afdc545b tests.nixpkgs-check-by-name: Enforce pkgs/by-name for new packages 2024-01-10 19:29:26 +01:00
Silvan Mosberger
92238ac52d tests.nixpkgs-check-by-name: Create script to run locally
Due to the check soon depending on the base branch (see `--base`),
the CI check can't reasonably share all code with a local check.
We can still make a script to run it locally, just not sharing all code.
2023-12-20 17:38:03 +01:00
Silvan Mosberger
6f2be7c095 pkgs/by-name: Mention possibility of avoiding alternate callPackage's
This is preferred over using the category hierarchy

Co-authored-by: Anderson Torres <torres.anderson.85@protonmail.com>
2023-12-06 23:29:27 +01:00
Samuel Tardieu
41acc25766 by-name: make the way of adding packages clearer 2023-10-09 19:12:29 +02:00
Silvan Mosberger
e27e30204b pkgs/by-name: Add manual migration guidelines
Motivated from seeing people starting to migrate packages manually when
it shouldn't be necessary or done differently.
2023-09-12 00:18:24 +02:00
Silvan Mosberger
488840d203 pkgs/by-name: Fix minor mistake in README 2023-09-06 19:29:43 +02:00
Silvan Mosberger
f6467c3574 pkgs/by-name: Introduce
This introduces the `pkgs/by-name` directory as proposed by RFC 140.
Included are:
- The implementation to add packages defined in that directory to the
  top-level package scope
- Contributer documentation on how to add packages to it
- A GitHub Actions workflow to check the structure of it on all PRs
2023-09-05 16:10:50 +02:00