From 76b40c3cc5c5e24bb686ab5f8f20aa8a3249823a Mon Sep 17 00:00:00 2001 From: James Eapen Date: Fri, 20 Feb 2026 12:51:40 -0500 Subject: [PATCH 1/2] rPackages.iscream: use pkgs.htslib without libdeflate override now that pkgs.htslib is built with libdeflate support --- pkgs/development/r-modules/default.nix | 20 +++++++------------- 1 file changed, 7 insertions(+), 13 deletions(-) diff --git a/pkgs/development/r-modules/default.nix b/pkgs/development/r-modules/default.nix index fb5bc3e25fc1..da2a712803ee 100644 --- a/pkgs/development/r-modules/default.nix +++ b/pkgs/development/r-modules/default.nix @@ -3136,19 +3136,13 @@ let ''; }); - iscream = - let - # https://huishenlab.github.io/iscream/articles/htslib.html - htslib-deflate = pkgs.htslib.overrideAttrs (attrs: { - buildInputs = attrs.buildInputs ++ [ pkgs.libdeflate ]; - }); - in - old.iscream.overrideAttrs (attrs: { - # Rhtslib (in LinkingTo) is not needed if we provide a proper htslib - propagatedBuildInputs = - builtins.filter (el: el != pkgs.rPackages.Rhtslib) attrs.propagatedBuildInputs - ++ [ htslib-deflate ]; - }); + iscream = old.iscream.overrideAttrs (attrs: { + # https://huishenlab.github.io/iscream/articles/htslib.html + # Rhtslib (in LinkingTo) is not needed if we provide a proper htslib + propagatedBuildInputs = + builtins.filter (el: el != pkgs.rPackages.Rhtslib) attrs.propagatedBuildInputs + ++ [ pkgs.htslib ]; + }); torch = old.torch.overrideAttrs (attrs: { preConfigure = '' From d2596d019d075a4453e632feac816cca607999ac Mon Sep 17 00:00:00 2001 From: James Eapen Date: Sun, 1 Mar 2026 17:01:40 -0500 Subject: [PATCH 2/2] rPackages.iscream: add maintainer jamespeapen --- maintainers/maintainer-list.nix | 6 ++++++ maintainers/team-list.nix | 1 + pkgs/development/r-modules/default.nix | 1 + 3 files changed, 8 insertions(+) diff --git a/maintainers/maintainer-list.nix b/maintainers/maintainer-list.nix index cecc92804e56..25e3c2127398 100644 --- a/maintainers/maintainer-list.nix +++ b/maintainers/maintainer-list.nix @@ -11828,6 +11828,12 @@ github = "james-atkins"; githubId = 9221409; }; + jamespeapen = { + name = "James Eapen"; + email = "james.eapen@vai.org"; + github = "jamespeapen"; + githubId = 39574560; + }; jamesward = { email = "james@jamesward.com"; name = "James Ward"; diff --git a/maintainers/team-list.nix b/maintainers/team-list.nix index bb000aa7676d..bad67fd029fe 100644 --- a/maintainers/team-list.nix +++ b/maintainers/team-list.nix @@ -686,6 +686,7 @@ with lib.maintainers; members = [ b-rodrigues bcdarwin + jamespeapen jbedo kupac ]; diff --git a/pkgs/development/r-modules/default.nix b/pkgs/development/r-modules/default.nix index da2a712803ee..1c47c74d4ecb 100644 --- a/pkgs/development/r-modules/default.nix +++ b/pkgs/development/r-modules/default.nix @@ -385,6 +385,7 @@ let data_table = [ jbedo ]; BiocManager = [ jbedo ]; ggplot2 = [ jbedo ]; + iscream = [ jamespeapen ]; svaNUMT = [ jbedo ]; svaRetro = [ jbedo ]; StructuralVariantAnnotation = [ jbedo ];