archives/nixpkgs
1
0
Fork 0
mirror of https://github.com/NixOS/nixpkgs.git synced 2026-03-08 03:24:06 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

ci/github-script/reviewers.js: Fix reviewer API request

Browse source 
It takes arrays, not sets, see https://github.com/NixOS/nixpkgs/actions/runs/21735690914/job/62700395870?pr=487491
This commit is contained in:
Silvan Mosberger 2026-02-07 13:50:46 +01:00
parent b0b2c24be9
commit 71e704768d
1 changed files with 14 additions and 13 deletions
Download patch file Download diff file Expand all files Collapse all files

27
ci/github-script/reviewers.js
View file

@ -139,26 +139,27 @@ async function handleReviewers({
}
// We don't want to rerequest reviews from people who already reviewed or were requested
const users_not_yet_reached = users_to_reach.difference(users_reached)
log(
'reviewers - users_not_yet_reached',
Array.from(users_not_yet_reached).join(', '),
const users_not_yet_reached = Array.from(
users_to_reach.difference(users_reached),
)
log('reviewers - users_not_yet_reached', users_not_yet_reached.join(', '))
// We don't want to rerequest reviews from teams who already reviewed or were requested
const teams_not_yet_reached = teams_to_reach.difference(teams_reached)
log(
'reviewers - teams_not_yet_reached',
Array.from(teams_not_yet_reached).join(', '),
const teams_not_yet_reached = Array.from(
teams_to_reach.difference(teams_reached),
)
log('reviewers - teams_not_yet_reached', teams_not_yet_reached.join(', '))
if (users_not_yet_reached.size === 0 && teams_not_yet_reached.size === 0) {
if (
users_not_yet_reached.length === 0 &&
teams_not_yet_reached.length === 0
) {
log('Has reviewer changes', 'false (skipped)')
} else if (dry) {
core.info(
`Requesting user reviewers for #${pull_number}: ${Array.from(users_not_yet_reached).join(', ')} (dry)`,
`Requesting user reviewers for #${pull_number}: ${users_not_yet_reached.join(', ')} (dry)`,
)
core.info(
`Requesting team reviewers for #${pull_number}: ${Array.from(teams_not_yet_reached).join(', ')} (dry)`,
`Requesting team reviewers for #${pull_number}: ${teams_not_yet_reached.join(', ')} (dry)`,
)
} else {
// We had tried the "request all reviewers at once" thing in the past, but it didn't work out:
@ -175,8 +176,8 @@ async function handleReviewers({
// Return a boolean on whether the "needs: reviewers" label should be set.
return (
users_not_yet_reached.size === 0 &&
teams_not_yet_reached.size === 0 &&
users_not_yet_reached.length === 0 &&
teams_not_yet_reached.length === 0 &&
users_reached.size === 0 &&
teams_reached.size === 0
)