Vladimir Oltean 0322ef49c1 net: dsa: seville: ignore mscc-miim read errors from Lynx PCS ... During the refactoring in the commit below, vsc9953_mdio_read() was replaced with mscc_miim_read(), which has one extra step: it checks for the MSCC_MIIM_DATA_ERROR bits before returning the result. On T1040RDB, there are 8 QSGMII PCSes belonging to the switch, and they are organized in 2 groups. First group responds to MDIO addresses 4-7 because QSGMIIACR1[MDEV_PORT] is 1, and the second group responds to MDIO addresses 8-11 because QSGMIIBCR1[MDEV_PORT] is 2. I have double checked that these values are correctly set in the SERDES, as well as PCCR1[QSGMA_CFG] and PCCR1[QSGMB_CFG] are both 0b01. mscc_miim_read: phyad 8 reg 0x1 MIIM_DATA 0x2d mscc_miim_read: phyad 8 reg 0x5 MIIM_DATA 0x5801 mscc_miim_read: phyad 8 reg 0x1 MIIM_DATA 0x2d mscc_miim_read: phyad 8 reg 0x5 MIIM_DATA 0x5801 mscc_miim_read: phyad 9 reg 0x1 MIIM_DATA 0x2d mscc_miim_read: phyad 9 reg 0x5 MIIM_DATA 0x5801 mscc_miim_read: phyad 9 reg 0x1 MIIM_DATA 0x2d mscc_miim_read: phyad 9 reg 0x5 MIIM_DATA 0x5801 mscc_miim_read: phyad 10 reg 0x1 MIIM_DATA 0x2d mscc_miim_read: phyad 10 reg 0x5 MIIM_DATA 0x5801 mscc_miim_read: phyad 10 reg 0x1 MIIM_DATA 0x2d mscc_miim_read: phyad 10 reg 0x5 MIIM_DATA 0x5801 mscc_miim_read: phyad 11 reg 0x1 MIIM_DATA 0x2d mscc_miim_read: phyad 11 reg 0x5 MIIM_DATA 0x5801 mscc_miim_read: phyad 11 reg 0x1 MIIM_DATA 0x2d mscc_miim_read: phyad 11 reg 0x5 MIIM_DATA 0x5801 mscc_miim_read: phyad 4 reg 0x1 MIIM_DATA 0x3002d, ERROR mscc_miim_read: phyad 4 reg 0x5 MIIM_DATA 0x3da01, ERROR mscc_miim_read: phyad 5 reg 0x1 MIIM_DATA 0x3002d, ERROR mscc_miim_read: phyad 5 reg 0x5 MIIM_DATA 0x35801, ERROR mscc_miim_read: phyad 5 reg 0x1 MIIM_DATA 0x3002d, ERROR mscc_miim_read: phyad 5 reg 0x5 MIIM_DATA 0x35801, ERROR mscc_miim_read: phyad 6 reg 0x1 MIIM_DATA 0x3002d, ERROR mscc_miim_read: phyad 6 reg 0x5 MIIM_DATA 0x35801, ERROR mscc_miim_read: phyad 6 reg 0x1 MIIM_DATA 0x3002d, ERROR mscc_miim_read: phyad 6 reg 0x5 MIIM_DATA 0x35801, ERROR mscc_miim_read: phyad 7 reg 0x1 MIIM_DATA 0x3002d, ERROR mscc_miim_read: phyad 7 reg 0x5 MIIM_DATA 0x35801, ERROR mscc_miim_read: phyad 7 reg 0x1 MIIM_DATA 0x3002d, ERROR mscc_miim_read: phyad 7 reg 0x5 MIIM_DATA 0x35801, ERROR As can be seen, the data in MIIM_DATA is still valid despite having the MSCC_MIIM_DATA_ERROR bits set. The driver as introduced in commit 84705fc165 ("net: dsa: felix: introduce support for Seville VSC9953 switch") was ignoring these bits, perhaps deliberately (although unbeknownst to me). This is an old IP and the hardware team cannot seem to be able to help me track down a plausible reason for these failures. I'll keep investigating, but in the meantime, this is a direct regression which must be restored to a working state. The only thing I can do is keep ignoring the errors as before. Fixes: b996584523 ("net: dsa: ocelot: felix: utilize shared mscc-miim driver for indirect MDIO access") Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com> Reviewed-by: Florian Fainelli <f.fainelli@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net>		2023-02-26 18:31:37 +00:00
..
acpi	ACPI updates for 6.3-rc1	2023-02-21 12:23:24 -08:00
asm-generic	hyperv-next for v6.3.	2023-02-21 16:59:23 -08:00
clocksource	Updates for timers, timekeeping and drivers:	2022-12-12 12:52:02 -08:00
crypto	crypto: api - Use data directly in completion function	2023-02-13 18:35:14 +08:00
drm	drm/client: fix circular reference counting issue	2023-02-07 09:42:56 +01:00
dt-bindings	Thermal control updates for 6.3-rc1	2023-02-21 12:32:05 -08:00
keys
kunit	kunit: fix kunit_test_init_section_suites(...)	2023-01-31 09:10:38 -07:00
kvm	KVM: arm64: Add helper vgic_write_guest_lock()	2023-01-29 18:46:11 +00:00
linux	net: dsa: seville: ignore mscc-miim read errors from Lynx PCS	2023-02-26 18:31:37 +00:00
math-emu
media	platform-drivers-x86 for v6.3-1	2023-02-21 17:32:50 -08:00
memory
misc
net	sctp: add a refcnt in sctp_stream_priorities to avoid a nested loop	2023-02-23 12:59:40 -08:00
pcmcia
ras
rdma
rv
scsi	scsi: iscsi_tcp: Fix UAF during logout when accessing the shost ipaddress	2023-01-18 19:14:56 -05:00
soc	net: mscc: ocelot: un-export unused regmap symbols	2023-02-06 22:33:15 -08:00
sound	ASoC: samsung: remove unused drivers	2023-01-16 09:26:06 +01:00
target
trace	Networking changes for 6.3.	2023-02-21 18:24:12 -08:00
uapi	netdev-genl: fix repeated typo oflloading -> offloading	2023-02-24 11:01:16 +00:00
ufs	scsi: ufs: core: Fix devfreq deadlocks	2023-01-18 19:08:37 -05:00
vdso	vdso/bits.h: Add BIT_ULL() for the sake of consistency	2023-01-31 14:42:10 +01:00
video	fbdev: remove w100fb driver	2023-02-01 17:23:38 +01:00
xen	xen: Allow platform PCI interrupt to be shared	2023-02-13 06:53:20 +01:00