mirror of
https://github.com/torvalds/linux.git
synced 2026-03-07 23:04:33 +01:00
The ARM64_WORKAROUND_REPEAT_TLBI workaround is used to mitigate several errata where broadcast TLBI;DSB sequences don't provide all the architecturally required synchronization. The workaround performs more work than necessary, and can have significant overhead. This patch optimizes the workaround, as explained below. The workaround was originally added for Qualcomm Falkor erratum 1009 in commit:d9ff80f83e("arm64: Work around Falkor erratum 1009") As noted in the message for that commit, the workaround is applied even in cases where it is not strictly necessary. The workaround was later reused without changes for: * Arm Cortex-A76 erratum #1286807 SDEN v33: https://developer.arm.com/documentation/SDEN-885749/33-0/ * Arm Cortex-A55 erratum #2441007 SDEN v16: https://developer.arm.com/documentation/SDEN-859338/1600/ * Arm Cortex-A510 erratum #2441009 SDEN v19: https://developer.arm.com/documentation/SDEN-1873351/1900/ The important details to note are as follows: 1. All relevant errata only affect the ordering and/or completion of memory accesses which have been translated by an invalidated TLB entry. The actual invalidation of TLB entries is unaffected. 2. The existing workaround is applied to both broadcast and local TLB invalidation, whereas for all relevant errata it is only necessary to apply a workaround for broadcast invalidation. 3. The existing workaround replaces every TLBI with a TLBI;DSB;TLBI sequence, whereas for all relevant errata it is only necessary to execute a single additional TLBI;DSB sequence after any number of TLBIs are completed by a DSB. For example, for a sequence of batched TLBIs: TLBI <op1>[, <arg1>] TLBI <op2>[, <arg2>] TLBI <op3>[, <arg3>] DSB ISH ... the existing workaround will expand this to: TLBI <op1>[, <arg1>] DSB ISH // additional TLBI <op1>[, <arg1>] // additional TLBI <op2>[, <arg2>] DSB ISH // additional TLBI <op2>[, <arg2>] // additional TLBI <op3>[, <arg3>] DSB ISH // additional TLBI <op3>[, <arg3>] // additional DSB ISH ... whereas it is sufficient to have: TLBI <op1>[, <arg1>] TLBI <op2>[, <arg2>] TLBI <op3>[, <arg3>] DSB ISH TLBI <opX>[, <argX>] // additional DSB ISH // additional Using a single additional TBLI and DSB at the end of the sequence can have significantly lower overhead as each DSB which completes a TLBI must synchronize with other PEs in the system, with potential performance effects both locally and system-wide. 4. The existing workaround repeats each specific TLBI operation, whereas for all relevant errata it is sufficient for the additional TLBI to use *any* operation which will be broadcast, regardless of which translation regime or stage of translation the operation applies to. For example, for a single TLBI: TLBI ALLE2IS DSB ISH ... the existing workaround will expand this to: TLBI ALLE2IS DSB ISH TLBI ALLE2IS // additional DSB ISH // additional ... whereas it is sufficient to have: TLBI ALLE2IS DSB ISH TLBI VALE1IS, XZR // additional DSB ISH // additional As the additional TLBI doesn't have to match a specific earlier TLBI, the additional TLBI can be implemented in separate code, with no memory of the earlier TLBIs. The additional TLBI can also use a cheaper TLBI operation. 5. The existing workaround is applied to both Stage-1 and Stage-2 TLB invalidation, whereas for all relevant errata it is only necessary to apply a workaround for Stage-1 invalidation. Architecturally, TLBI operations which invalidate only Stage-2 information (e.g. IPAS2E1IS) are not required to invalidate TLB entries which combine information from Stage-1 and Stage-2 translation table entries, and consequently may not complete memory accesses translated by those combined entries. In these cases, completion of memory accesses is only guaranteed after subsequent invalidation of Stage-1 information (e.g. VMALLE1IS). Taking the above points into account, this patch reworks the workaround logic to reduce overhead: * New __tlbi_sync_s1ish() and __tlbi_sync_s1ish_hyp() functions are added and used in place of any dsb(ish) which is used to complete broadcast Stage-1 TLB maintenance. When the ARM64_WORKAROUND_REPEAT_TLBI workaround is enabled, these helpers will execute an additional TLBI;DSB sequence. For consistency, it might make sense to add __tlbi_sync_*() helpers for local and stage 2 maintenance. For now I've left those with open-coded dsb() to keep the diff small. * The duplication of TLBIs in __TLBI_0() and __TLBI_1() is removed. This is no longer needed as the necessary synchronization will happen in __tlbi_sync_s1ish() or __tlbi_sync_s1ish_hyp(). * The additional TLBI operation is chosen to have minimal impact: - __tlbi_sync_s1ish() uses "TLBI VALE1IS, XZR". This is only used at EL1 or at EL2 with {E2H,TGE}=={1,1}, where it will target an unused entry for the reserved ASID in the kernel's own translation regime, and have no adverse affect. - __tlbi_sync_s1ish_hyp() uses "TLBI VALE2IS, XZR". This is only used in hyp code, where it will target an unused entry in the hyp code's TTBR0 mapping, and should have no adverse effect. * As __TLBI_0() and __TLBI_1() no longer replace each TLBI with a TLBI;DSB;TLBI sequence, batching TLBIs is worthwhile, and there's no need for arch_tlbbatch_should_defer() to consider ARM64_WORKAROUND_REPEAT_TLBI. When building defconfig with GCC 15.1.0, compared to v6.19-rc1, this patch saves ~1KiB of text, makes the vmlinux ~42KiB smaller, and makes the resulting Image 64KiB smaller: | [mark@lakrids:~/src/linux]% size vmlinux-* | text data bss dec hex filename | 21179831 19660919 70821641548966279fca6 vmlinux-after | 21181075 19660903 708216 41550194 27a0172 vmlinux-before | [mark@lakrids:~/src/linux]% ls -l vmlinux-* | -rwxr-xr-x 1 mark mark 157771472 Feb 4 12:05 vmlinux-after | -rwxr-xr-x 1 mark mark 157815432 Feb 4 12:05 vmlinux-before | [mark@lakrids:~/src/linux]% ls -l Image-* | -rw-r--r-- 1 mark mark 41007616 Feb 4 12:05 Image-after | -rw-r--r-- 1 mark mark 41073152 Feb 4 12:05 Image-before Signed-off-by: Mark Rutland <mark.rutland@arm.com> Cc: Catalin Marinas <catalin.marinas@arm.com> Cc: Marc Zyngier <maz@kernel.org> Cc: Oliver Upton <oupton@kernel.org> Cc: Ryan Roberts <ryan.roberts@arm.com> Cc: Will Deacon <will@kernel.org> Signed-off-by: Will Deacon <will@kernel.org>
270 lines
6.2 KiB
C
270 lines
6.2 KiB
C
// SPDX-License-Identifier: GPL-2.0-only
|
|
/*
|
|
* Copyright (C) 2015 - ARM Ltd
|
|
* Author: Marc Zyngier <marc.zyngier@arm.com>
|
|
*/
|
|
|
|
#include <asm/kvm_hyp.h>
|
|
#include <asm/kvm_mmu.h>
|
|
#include <asm/tlbflush.h>
|
|
|
|
#include <nvhe/mem_protect.h>
|
|
|
|
struct tlb_inv_context {
|
|
struct kvm_s2_mmu *mmu;
|
|
u64 tcr;
|
|
u64 sctlr;
|
|
};
|
|
|
|
static void enter_vmid_context(struct kvm_s2_mmu *mmu,
|
|
struct tlb_inv_context *cxt,
|
|
bool nsh)
|
|
{
|
|
struct kvm_s2_mmu *host_s2_mmu = &host_mmu.arch.mmu;
|
|
struct kvm_cpu_context *host_ctxt;
|
|
struct kvm_vcpu *vcpu;
|
|
|
|
host_ctxt = &this_cpu_ptr(&kvm_host_data)->host_ctxt;
|
|
vcpu = host_ctxt->__hyp_running_vcpu;
|
|
cxt->mmu = NULL;
|
|
|
|
/*
|
|
* We have two requirements:
|
|
*
|
|
* - ensure that the page table updates are visible to all
|
|
* CPUs, for which a dsb(DOMAIN-st) is what we need, DOMAIN
|
|
* being either ish or nsh, depending on the invalidation
|
|
* type.
|
|
*
|
|
* - complete any speculative page table walk started before
|
|
* we trapped to EL2 so that we can mess with the MM
|
|
* registers out of context, for which dsb(nsh) is enough
|
|
*
|
|
* The composition of these two barriers is a dsb(DOMAIN), and
|
|
* the 'nsh' parameter tracks the distinction between
|
|
* Inner-Shareable and Non-Shareable, as specified by the
|
|
* callers.
|
|
*/
|
|
if (nsh)
|
|
dsb(nsh);
|
|
else
|
|
dsb(ish);
|
|
|
|
/*
|
|
* If we're already in the desired context, then there's nothing to do.
|
|
*/
|
|
if (vcpu) {
|
|
/*
|
|
* We're in guest context. However, for this to work, this needs
|
|
* to be called from within __kvm_vcpu_run(), which ensures that
|
|
* __hyp_running_vcpu is set to the current guest vcpu.
|
|
*/
|
|
if (mmu == vcpu->arch.hw_mmu || WARN_ON(mmu != host_s2_mmu))
|
|
return;
|
|
|
|
cxt->mmu = vcpu->arch.hw_mmu;
|
|
} else {
|
|
/* We're in host context. */
|
|
if (mmu == host_s2_mmu)
|
|
return;
|
|
|
|
cxt->mmu = host_s2_mmu;
|
|
}
|
|
|
|
if (cpus_have_final_cap(ARM64_WORKAROUND_SPECULATIVE_AT)) {
|
|
u64 val;
|
|
|
|
/*
|
|
* For CPUs that are affected by ARM 1319367, we need to
|
|
* avoid a Stage-1 walk with the old VMID while we have
|
|
* the new VMID set in the VTTBR in order to invalidate TLBs.
|
|
* We're guaranteed that the host S1 MMU is enabled, so
|
|
* we can simply set the EPD bits to avoid any further
|
|
* TLB fill. For guests, we ensure that the S1 MMU is
|
|
* temporarily enabled in the next context.
|
|
*/
|
|
val = cxt->tcr = read_sysreg_el1(SYS_TCR);
|
|
val |= TCR_EPD1_MASK | TCR_EPD0_MASK;
|
|
write_sysreg_el1(val, SYS_TCR);
|
|
isb();
|
|
|
|
if (vcpu) {
|
|
val = cxt->sctlr = read_sysreg_el1(SYS_SCTLR);
|
|
if (!(val & SCTLR_ELx_M)) {
|
|
val |= SCTLR_ELx_M;
|
|
write_sysreg_el1(val, SYS_SCTLR);
|
|
isb();
|
|
}
|
|
} else {
|
|
/* The host S1 MMU is always enabled. */
|
|
cxt->sctlr = SCTLR_ELx_M;
|
|
}
|
|
}
|
|
|
|
/*
|
|
* __load_stage2() includes an ISB only when the AT
|
|
* workaround is applied. Take care of the opposite condition,
|
|
* ensuring that we always have an ISB, but not two ISBs back
|
|
* to back.
|
|
*/
|
|
if (vcpu)
|
|
__load_host_stage2();
|
|
else
|
|
__load_stage2(mmu, kern_hyp_va(mmu->arch));
|
|
|
|
asm(ALTERNATIVE("isb", "nop", ARM64_WORKAROUND_SPECULATIVE_AT));
|
|
}
|
|
|
|
static void exit_vmid_context(struct tlb_inv_context *cxt)
|
|
{
|
|
struct kvm_s2_mmu *mmu = cxt->mmu;
|
|
struct kvm_cpu_context *host_ctxt;
|
|
struct kvm_vcpu *vcpu;
|
|
|
|
host_ctxt = &this_cpu_ptr(&kvm_host_data)->host_ctxt;
|
|
vcpu = host_ctxt->__hyp_running_vcpu;
|
|
|
|
if (!mmu)
|
|
return;
|
|
|
|
if (vcpu)
|
|
__load_stage2(mmu, kern_hyp_va(mmu->arch));
|
|
else
|
|
__load_host_stage2();
|
|
|
|
/* Ensure write of the old VMID */
|
|
isb();
|
|
|
|
if (cpus_have_final_cap(ARM64_WORKAROUND_SPECULATIVE_AT)) {
|
|
if (!(cxt->sctlr & SCTLR_ELx_M)) {
|
|
write_sysreg_el1(cxt->sctlr, SYS_SCTLR);
|
|
isb();
|
|
}
|
|
|
|
write_sysreg_el1(cxt->tcr, SYS_TCR);
|
|
}
|
|
}
|
|
|
|
void __kvm_tlb_flush_vmid_ipa(struct kvm_s2_mmu *mmu,
|
|
phys_addr_t ipa, int level)
|
|
{
|
|
struct tlb_inv_context cxt;
|
|
|
|
/* Switch to requested VMID */
|
|
enter_vmid_context(mmu, &cxt, false);
|
|
|
|
/*
|
|
* We could do so much better if we had the VA as well.
|
|
* Instead, we invalidate Stage-2 for this IPA, and the
|
|
* whole of Stage-1. Weep...
|
|
*/
|
|
ipa >>= 12;
|
|
__tlbi_level(ipas2e1is, ipa, level);
|
|
|
|
/*
|
|
* We have to ensure completion of the invalidation at Stage-2,
|
|
* since a table walk on another CPU could refill a TLB with a
|
|
* complete (S1 + S2) walk based on the old Stage-2 mapping if
|
|
* the Stage-1 invalidation happened first.
|
|
*/
|
|
dsb(ish);
|
|
__tlbi(vmalle1is);
|
|
__tlbi_sync_s1ish_hyp();
|
|
isb();
|
|
|
|
exit_vmid_context(&cxt);
|
|
}
|
|
|
|
void __kvm_tlb_flush_vmid_ipa_nsh(struct kvm_s2_mmu *mmu,
|
|
phys_addr_t ipa, int level)
|
|
{
|
|
struct tlb_inv_context cxt;
|
|
|
|
/* Switch to requested VMID */
|
|
enter_vmid_context(mmu, &cxt, true);
|
|
|
|
/*
|
|
* We could do so much better if we had the VA as well.
|
|
* Instead, we invalidate Stage-2 for this IPA, and the
|
|
* whole of Stage-1. Weep...
|
|
*/
|
|
ipa >>= 12;
|
|
__tlbi_level(ipas2e1, ipa, level);
|
|
|
|
/*
|
|
* We have to ensure completion of the invalidation at Stage-2,
|
|
* since a table walk on another CPU could refill a TLB with a
|
|
* complete (S1 + S2) walk based on the old Stage-2 mapping if
|
|
* the Stage-1 invalidation happened first.
|
|
*/
|
|
dsb(nsh);
|
|
__tlbi(vmalle1);
|
|
dsb(nsh);
|
|
isb();
|
|
|
|
exit_vmid_context(&cxt);
|
|
}
|
|
|
|
void __kvm_tlb_flush_vmid_range(struct kvm_s2_mmu *mmu,
|
|
phys_addr_t start, unsigned long pages)
|
|
{
|
|
struct tlb_inv_context cxt;
|
|
unsigned long stride;
|
|
|
|
/*
|
|
* Since the range of addresses may not be mapped at
|
|
* the same level, assume the worst case as PAGE_SIZE
|
|
*/
|
|
stride = PAGE_SIZE;
|
|
start = round_down(start, stride);
|
|
|
|
/* Switch to requested VMID */
|
|
enter_vmid_context(mmu, &cxt, false);
|
|
|
|
__flush_s2_tlb_range_op(ipas2e1is, start, pages, stride,
|
|
TLBI_TTL_UNKNOWN);
|
|
|
|
dsb(ish);
|
|
__tlbi(vmalle1is);
|
|
__tlbi_sync_s1ish_hyp();
|
|
isb();
|
|
|
|
exit_vmid_context(&cxt);
|
|
}
|
|
|
|
void __kvm_tlb_flush_vmid(struct kvm_s2_mmu *mmu)
|
|
{
|
|
struct tlb_inv_context cxt;
|
|
|
|
/* Switch to requested VMID */
|
|
enter_vmid_context(mmu, &cxt, false);
|
|
|
|
__tlbi(vmalls12e1is);
|
|
__tlbi_sync_s1ish_hyp();
|
|
isb();
|
|
|
|
exit_vmid_context(&cxt);
|
|
}
|
|
|
|
void __kvm_flush_cpu_context(struct kvm_s2_mmu *mmu)
|
|
{
|
|
struct tlb_inv_context cxt;
|
|
|
|
/* Switch to requested VMID */
|
|
enter_vmid_context(mmu, &cxt, false);
|
|
|
|
__tlbi(vmalle1);
|
|
asm volatile("ic iallu");
|
|
dsb(nsh);
|
|
isb();
|
|
|
|
exit_vmid_context(&cxt);
|
|
}
|
|
|
|
void __kvm_flush_vm_context(void)
|
|
{
|
|
/* Same remark as in enter_vmid_context() */
|
|
dsb(ish);
|
|
__tlbi(alle1is);
|
|
__tlbi_sync_s1ish_hyp();
|
|
}
|