linux/drivers/dpll
Ivan Vecera 5d41f95f5d dpll: zl3073x: Fix output pin phase adjustment sign
The output pin phase adjustment functions incorrectly negate the phase
compensation value.

Per the ZL3073x datasheet, the output phase compensation register is
simply a signed two's complement integer where:
 - Positive values move the phase later in time
 - Negative values move the phase earlier in time

No negation is required. The erroneous negation caused phase adjustments
to be applied in the wrong direction.

Note that input pin phase adjustment correctly uses negation because the
hardware has an inverted convention for input references (positive moves
phase earlier, negative moves phase later).

Fixes: 6287262f76 ("dpll: zl3073x: Add support to adjust phase")
Signed-off-by: Ivan Vecera <ivecera@redhat.com>
Reviewed-by: Vadim Fedorenko <vadim.fedorenko@linux.dev>
Link: https://patch.msgid.link/20260205181055.129768-1-ivecera@redhat.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
2026-02-06 20:36:37 -08:00
..
zl3073x dpll: zl3073x: Fix output pin phase adjustment sign 2026-02-06 20:36:37 -08:00
dpll_core.c dpll: Prevent duplicate registrations 2026-01-22 08:08:42 -08:00
dpll_core.h dpll: add reference sync get/set 2025-06-27 16:38:02 -07:00
dpll_netlink.c dpll: add phase-adjust-gran pin attribute 2025-10-31 17:59:17 -07:00
dpll_netlink.h dpll: add reference sync get/set 2025-06-27 16:38:02 -07:00
dpll_nl.c tools: ynl-gen: add regeneration comment 2025-11-25 19:20:42 -08:00
dpll_nl.h tools: ynl-gen: add regeneration comment 2025-11-25 19:20:42 -08:00
Kconfig dpll: Add basic Microchip ZL3073x support 2025-07-09 19:08:52 -07:00
Makefile dpll: Add basic Microchip ZL3073x support 2025-07-09 19:08:52 -07:00