mirror of
https://github.com/torvalds/linux.git
synced 2026-03-08 04:04:43 +01:00
4478e8eeb8
The convention for KUnit tests is to have the test kconfig options visible only when the code they depend on is already enabled. This way only the tests that are relevant to the particular kernel build can be enabled, either manually or via KUNIT_ALL_TESTS. Update lib/crypto/tests/Kconfig to follow that convention, i.e. depend on the corresponding library options rather than selecting them. This fixes an issue where enabling KUNIT_ALL_TESTS enabled non-test code. This does mean that it becomes a bit more difficult to enable *all* the crypto library tests (which is what I do as a maintainer of the code), since doing so will now require enabling other options that select the libraries. Regardless, we should follow the standard KUnit convention. I'll also add a .kunitconfig file that does enable all these options. Note: currently most of the crypto library options are selected by visible options in crypto/Kconfig, which can be used to enable them without too much trouble. If in the future we end up with more cases like CRYPTO_LIB_CURVE25519 which is selected only by WIREGUARD (thus making CRYPTO_LIB_CURVE25519_KUNIT_TEST effectively depend on WIREGUARD after this commit), we could consider adding a new kconfig option that enables all the library code specifically for testing. Reported-by: Geert Uytterhoeven <geert@linux-m68k.org> Closes: https://lore.kernel.org/r/CAMuHMdULzMdxuTVfg8_4jdgzbzjfx-PHkcgbGSthcUx_sHRNMg@mail.gmail.com Fixes: |
||
|---|---|---|
| .. | ||
| arm | ||
| arm64 | ||
| mips | ||
| mpi | ||
| powerpc | ||
| riscv | ||
| s390 | ||
| sparc | ||
| tests | ||
| x86 | ||
| aes.c | ||
| aescfb.c | ||
| aesgcm.c | ||
| arc4.c | ||
| blake2b.c | ||
| blake2s.c | ||
| chacha-block-generic.c | ||
| chacha.c | ||
| chacha20poly1305-selftest.c | ||
| chacha20poly1305.c | ||
| curve25519-fiat32.c | ||
| curve25519-hacl64.c | ||
| curve25519.c | ||
| des.c | ||
| fips-mldsa.h | ||
| fips.h | ||
| gf128mul.c | ||
| hash_info.c | ||
| Kconfig | ||
| Makefile | ||
| md5.c | ||
| memneq.c | ||
| mldsa.c | ||
| nh.c | ||
| poly1305-donna32.c | ||
| poly1305-donna64.c | ||
| poly1305.c | ||
| polyval.c | ||
| sha1.c | ||
| sha3.c | ||
| sha256.c | ||
| sha512.c | ||
| simd.c | ||
| sm3.c | ||
| utils.c | ||