Haiyang Zhang c0de6ab920 net: mana: Fix Rx DMA datasize and skb_over_panic ... mana_get_rxbuf_cfg() aligns the RX buffer's DMA datasize to be multiple of 64. So a packet slightly bigger than mtu+14, say 1536, can be received and cause skb_over_panic. Sample dmesg: [ 5325.237162] skbuff: skb_over_panic: text:ffffffffc043277a len:1536 put:1536 head:ff1100018b517000 data:ff1100018b517100 tail:0x700 end:0x6ea dev:<NULL> [ 5325.243689] ------------[ cut here ]------------ [ 5325.245748] kernel BUG at net/core/skbuff.c:192! [ 5325.247838] invalid opcode: 0000 [#1] PREEMPT SMP NOPTI [ 5325.258374] RIP: 0010:skb_panic+0x4f/0x60 [ 5325.302941] Call Trace: [ 5325.304389] <IRQ> [ 5325.315794] ? skb_panic+0x4f/0x60 [ 5325.317457] ? asm_exc_invalid_op+0x1f/0x30 [ 5325.319490] ? skb_panic+0x4f/0x60 [ 5325.321161] skb_put+0x4e/0x50 [ 5325.322670] mana_poll+0x6fa/0xb50 [mana] [ 5325.324578] __napi_poll+0x33/0x1e0 [ 5325.326328] net_rx_action+0x12e/0x280 As discussed internally, this alignment is not necessary. To fix this bug, remove it from the code. So oversized packets will be marked as CQE_RX_TRUNCATED by NIC, and dropped. Cc: stable@vger.kernel.org Fixes: 2fbbd712ba ("net: mana: Enable RX path to handle various MTU sizes") Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com> Reviewed-by: Dexuan Cui <decui@microsoft.com> Link: https://lore.kernel.org/r/1712087316-20886-1-git-send-email-haiyangz@microsoft.com Signed-off-by: Jakub Kicinski <kuba@kernel.org>		2024-04-03 19:32:03 -07:00
..
acpi	ACPI updates for 6.9-rc1	2024-03-13 11:54:05 -07:00
asm-generic	RISC-V Patches for the 6.9 Merge Window	2024-03-22 10:41:13 -07:00
clocksource
crypto	This update includes the following changes:	2024-03-15 14:46:54 -07:00
drm	drm fixes for 6.9-rc1	2024-03-21 19:04:31 -07:00
dt-bindings	Char/Misc and other driver subsystem updates for 6.9-rc1	2024-03-21 13:21:31 -07:00
keys
kunit	kunit: Annotate _MSG assertion variants with gnu printf specifiers	2024-02-28 13:07:49 -07:00
kvm	Merge branch kvm-arm64/lpi-xarray into kvmarm/next	2024-03-07 00:55:53 +00:00
linux	udp: do not accept non-tunnel GSO skbs landing in a tunnel	2024-03-29 11:30:43 +00:00
math-emu
media	media updates for v6.9-rc1	2024-03-15 11:36:54 -07:00
memory
misc
net	net: mana: Fix Rx DMA datasize and skb_over_panic	2024-04-03 19:32:03 -07:00
pcmcia
ras	PCI/AER: Generalize TLP Header Log reading	2024-03-08 15:26:46 -06:00
rdma	RDMA/uverbs: Avoid -Wflex-array-member-not-at-end warnings	2024-03-03 15:38:44 +02:00
rv
scsi	SCSI misc on 20240322	2024-03-22 13:31:07 -07:00
soc	Char/Misc and other driver subsystem updates for 6.9-rc1	2024-03-21 13:21:31 -07:00
sound	sound updates for 6.9-rc1	2024-03-14 11:10:43 -07:00
target
trace	tracing: Just use strcmp() for testing __string() and __assign_str() match	2024-03-19 11:23:30 -07:00
uapi	TTY/Serial driver update for 6.9-rc1	2024-03-21 12:44:10 -07:00
ufs
vdso	vdso/datapage: Quick fix - use asm/page-def.h for ARM64	2024-02-26 23:13:41 +01:00
video
xen