mirror of
https://github.com/torvalds/linux.git
synced 2026-03-08 01:04:41 +01:00
There was a lockdep warning in sprd_gpio: [ 6.258269][T329@C6] [ BUG: Invalid wait context ] [ 6.258270][T329@C6] 6.18.0-android17-0-g30527ad7aaae-ab00009-4k #1 Tainted: G W OE [ 6.258272][T329@C6] ----------------------------- [ 6.258273][T329@C6] modprobe/329 is trying to lock: [ 6.258275][T329@C6] ffffff8081c91690 (&sprd_gpio->lock){....}-{3:3}, at: sprd_gpio_irq_unmask+0x4c/0xa4 [gpio_sprd] [ 6.258282][T329@C6] other info that might help us debug this: [ 6.258283][T329@C6] context-{5:5} [ 6.258285][T329@C6] 3 locks held by modprobe/329: [ 6.258286][T329@C6] #0: ffffff808baca108 (&dev->mutex){....}-{4:4}, at: __driver_attach+0xc4/0x204 [ 6.258295][T329@C6] #1: ffffff80965e7240 (request_class#4){+.+.}-{4:4}, at: __setup_irq+0x1cc/0x82c [ 6.258304][T329@C6] #2: ffffff80965e70c8 (lock_class#4){....}-{2:2}, at: __setup_irq+0x21c/0x82c [ 6.258313][T329@C6] stack backtrace: [ 6.258314][T329@C6] CPU: 6 UID: 0 PID: 329 Comm: modprobe Tainted: G W OE 6.18.0-android17-0-g30527ad7aaae-ab00009-4k #1 PREEMPT 3ad5b0f45741a16e5838da790706e16ceb6717df [ 6.258316][T329@C6] Tainted: [W]=WARN, [O]=OOT_MODULE, [E]=UNSIGNED_MODULE [ 6.258317][T329@C6] Hardware name: Unisoc UMS9632-base Board (DT) [ 6.258318][T329@C6] Call trace: [ 6.258318][T329@C6] show_stack+0x20/0x30 (C) [ 6.258321][T329@C6] __dump_stack+0x28/0x3c [ 6.258324][T329@C6] dump_stack_lvl+0xac/0xf0 [ 6.258326][T329@C6] dump_stack+0x18/0x3c [ 6.258329][T329@C6] __lock_acquire+0x824/0x2c28 [ 6.258331][T329@C6] lock_acquire+0x148/0x2cc [ 6.258333][T329@C6] _raw_spin_lock_irqsave+0x6c/0xb4 [ 6.258334][T329@C6] sprd_gpio_irq_unmask+0x4c/0xa4 [gpio_sprd 814535e93c6d8e0853c45c02eab0fa88a9da6487] [ 6.258337][T329@C6] irq_startup+0x238/0x350 [ 6.258340][T329@C6] __setup_irq+0x504/0x82c [ 6.258342][T329@C6] request_threaded_irq+0x118/0x184 [ 6.258344][T329@C6] devm_request_threaded_irq+0x94/0x120 [ 6.258347][T329@C6] sc8546_init_irq+0x114/0x170 [sc8546_charger 223586ccafc27439f7db4f95b0c8e6e882349a99] [ 6.258352][T329@C6] sc8546_charger_probe+0x53c/0x5a0 [sc8546_charger 223586ccafc27439f7db4f95b0c8e6e882349a99] [ 6.258358][T329@C6] i2c_device_probe+0x2c8/0x350 [ 6.258361][T329@C6] really_probe+0x1a8/0x46c [ 6.258363][T329@C6] __driver_probe_device+0xa4/0x10c [ 6.258366][T329@C6] driver_probe_device+0x44/0x1b4 [ 6.258369][T329@C6] __driver_attach+0xd0/0x204 [ 6.258371][T329@C6] bus_for_each_dev+0x10c/0x168 [ 6.258373][T329@C6] driver_attach+0x2c/0x3c [ 6.258376][T329@C6] bus_add_driver+0x154/0x29c [ 6.258378][T329@C6] driver_register+0x70/0x10c [ 6.258381][T329@C6] i2c_register_driver+0x48/0xc8 [ 6.258384][T329@C6] init_module+0x28/0xfd8 [sc8546_charger 223586ccafc27439f7db4f95b0c8e6e882349a99] [ 6.258389][T329@C6] do_one_initcall+0x128/0x42c [ 6.258392][T329@C6] do_init_module+0x60/0x254 [ 6.258395][T329@C6] load_module+0x1054/0x1220 [ 6.258397][T329@C6] __arm64_sys_finit_module+0x240/0x35c [ 6.258400][T329@C6] invoke_syscall+0x60/0xec [ 6.258402][T329@C6] el0_svc_common+0xb0/0xe4 [ 6.258405][T329@C6] do_el0_svc+0x24/0x30 [ 6.258407][T329@C6] el0_svc+0x54/0x1c4 [ 6.258409][T329@C6] el0t_64_sync_handler+0x68/0xdc [ 6.258411][T329@C6] el0t_64_sync+0x1c4/0x1c8 This is because the spin_lock would change to rt_mutex in PREEMPT_RT, however the sprd_gpio->lock would use in hard-irq, this is unsafe. So change the spin_lock_t to raw_spin_lock_t to use the spinlock in hard-irq. Signed-off-by: Xuewen Yan <xuewen.yan@unisoc.com> Reviewed-by: Baolin Wang <baolin.wang@linux.alibaba.com> Reviewed-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de> Link: https://lore.kernel.org/r/20260126094209.9855-1-xuewen.yan@unisoc.com [Bartosz: tweaked the commit message] Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
281 lines
7.9 KiB
C
281 lines
7.9 KiB
C
// SPDX-License-Identifier: GPL-2.0
|
|
/*
|
|
* Copyright (C) 2018 Spreadtrum Communications Inc.
|
|
* Copyright (C) 2018 Linaro Ltd.
|
|
*/
|
|
|
|
#include <linux/bitops.h>
|
|
#include <linux/gpio/driver.h>
|
|
#include <linux/kernel.h>
|
|
#include <linux/mod_devicetable.h>
|
|
#include <linux/module.h>
|
|
#include <linux/platform_device.h>
|
|
#include <linux/spinlock.h>
|
|
|
|
/* GPIO registers definition */
|
|
#define SPRD_GPIO_DATA 0x0
|
|
#define SPRD_GPIO_DMSK 0x4
|
|
#define SPRD_GPIO_DIR 0x8
|
|
#define SPRD_GPIO_IS 0xc
|
|
#define SPRD_GPIO_IBE 0x10
|
|
#define SPRD_GPIO_IEV 0x14
|
|
#define SPRD_GPIO_IE 0x18
|
|
#define SPRD_GPIO_RIS 0x1c
|
|
#define SPRD_GPIO_MIS 0x20
|
|
#define SPRD_GPIO_IC 0x24
|
|
#define SPRD_GPIO_INEN 0x28
|
|
|
|
/* We have 16 banks GPIOs and each bank contain 16 GPIOs */
|
|
#define SPRD_GPIO_BANK_NR 16
|
|
#define SPRD_GPIO_NR 256
|
|
#define SPRD_GPIO_BANK_SIZE 0x80
|
|
#define SPRD_GPIO_BANK_MASK GENMASK(15, 0)
|
|
#define SPRD_GPIO_BIT(x) ((x) & (SPRD_GPIO_BANK_NR - 1))
|
|
|
|
struct sprd_gpio {
|
|
struct gpio_chip chip;
|
|
void __iomem *base;
|
|
raw_spinlock_t lock;
|
|
int irq;
|
|
};
|
|
|
|
static inline void __iomem *sprd_gpio_bank_base(struct sprd_gpio *sprd_gpio,
|
|
unsigned int bank)
|
|
{
|
|
return sprd_gpio->base + SPRD_GPIO_BANK_SIZE * bank;
|
|
}
|
|
|
|
static void sprd_gpio_update(struct gpio_chip *chip, unsigned int offset,
|
|
u16 reg, int val)
|
|
{
|
|
struct sprd_gpio *sprd_gpio = gpiochip_get_data(chip);
|
|
void __iomem *base = sprd_gpio_bank_base(sprd_gpio,
|
|
offset / SPRD_GPIO_BANK_NR);
|
|
unsigned long flags;
|
|
u32 tmp;
|
|
|
|
raw_spin_lock_irqsave(&sprd_gpio->lock, flags);
|
|
tmp = readl_relaxed(base + reg);
|
|
|
|
if (val)
|
|
tmp |= BIT(SPRD_GPIO_BIT(offset));
|
|
else
|
|
tmp &= ~BIT(SPRD_GPIO_BIT(offset));
|
|
|
|
writel_relaxed(tmp, base + reg);
|
|
raw_spin_unlock_irqrestore(&sprd_gpio->lock, flags);
|
|
}
|
|
|
|
static int sprd_gpio_read(struct gpio_chip *chip, unsigned int offset, u16 reg)
|
|
{
|
|
struct sprd_gpio *sprd_gpio = gpiochip_get_data(chip);
|
|
void __iomem *base = sprd_gpio_bank_base(sprd_gpio,
|
|
offset / SPRD_GPIO_BANK_NR);
|
|
|
|
return !!(readl_relaxed(base + reg) & BIT(SPRD_GPIO_BIT(offset)));
|
|
}
|
|
|
|
static int sprd_gpio_request(struct gpio_chip *chip, unsigned int offset)
|
|
{
|
|
sprd_gpio_update(chip, offset, SPRD_GPIO_DMSK, 1);
|
|
return 0;
|
|
}
|
|
|
|
static void sprd_gpio_free(struct gpio_chip *chip, unsigned int offset)
|
|
{
|
|
sprd_gpio_update(chip, offset, SPRD_GPIO_DMSK, 0);
|
|
}
|
|
|
|
static int sprd_gpio_direction_input(struct gpio_chip *chip,
|
|
unsigned int offset)
|
|
{
|
|
sprd_gpio_update(chip, offset, SPRD_GPIO_DIR, 0);
|
|
sprd_gpio_update(chip, offset, SPRD_GPIO_INEN, 1);
|
|
return 0;
|
|
}
|
|
|
|
static int sprd_gpio_direction_output(struct gpio_chip *chip,
|
|
unsigned int offset, int value)
|
|
{
|
|
sprd_gpio_update(chip, offset, SPRD_GPIO_DIR, 1);
|
|
sprd_gpio_update(chip, offset, SPRD_GPIO_INEN, 0);
|
|
sprd_gpio_update(chip, offset, SPRD_GPIO_DATA, value);
|
|
return 0;
|
|
}
|
|
|
|
static int sprd_gpio_get(struct gpio_chip *chip, unsigned int offset)
|
|
{
|
|
return sprd_gpio_read(chip, offset, SPRD_GPIO_DATA);
|
|
}
|
|
|
|
static int sprd_gpio_set(struct gpio_chip *chip, unsigned int offset,
|
|
int value)
|
|
{
|
|
sprd_gpio_update(chip, offset, SPRD_GPIO_DATA, value);
|
|
|
|
return 0;
|
|
}
|
|
|
|
static void sprd_gpio_irq_mask(struct irq_data *data)
|
|
{
|
|
struct gpio_chip *chip = irq_data_get_irq_chip_data(data);
|
|
u32 offset = irqd_to_hwirq(data);
|
|
|
|
sprd_gpio_update(chip, offset, SPRD_GPIO_IE, 0);
|
|
gpiochip_disable_irq(chip, offset);
|
|
}
|
|
|
|
static void sprd_gpio_irq_ack(struct irq_data *data)
|
|
{
|
|
struct gpio_chip *chip = irq_data_get_irq_chip_data(data);
|
|
u32 offset = irqd_to_hwirq(data);
|
|
|
|
sprd_gpio_update(chip, offset, SPRD_GPIO_IC, 1);
|
|
}
|
|
|
|
static void sprd_gpio_irq_unmask(struct irq_data *data)
|
|
{
|
|
struct gpio_chip *chip = irq_data_get_irq_chip_data(data);
|
|
u32 offset = irqd_to_hwirq(data);
|
|
|
|
sprd_gpio_update(chip, offset, SPRD_GPIO_IE, 1);
|
|
gpiochip_enable_irq(chip, offset);
|
|
}
|
|
|
|
static int sprd_gpio_irq_set_type(struct irq_data *data,
|
|
unsigned int flow_type)
|
|
{
|
|
struct gpio_chip *chip = irq_data_get_irq_chip_data(data);
|
|
u32 offset = irqd_to_hwirq(data);
|
|
|
|
switch (flow_type) {
|
|
case IRQ_TYPE_EDGE_RISING:
|
|
sprd_gpio_update(chip, offset, SPRD_GPIO_IS, 0);
|
|
sprd_gpio_update(chip, offset, SPRD_GPIO_IBE, 0);
|
|
sprd_gpio_update(chip, offset, SPRD_GPIO_IEV, 1);
|
|
sprd_gpio_update(chip, offset, SPRD_GPIO_IC, 1);
|
|
irq_set_handler_locked(data, handle_edge_irq);
|
|
break;
|
|
case IRQ_TYPE_EDGE_FALLING:
|
|
sprd_gpio_update(chip, offset, SPRD_GPIO_IS, 0);
|
|
sprd_gpio_update(chip, offset, SPRD_GPIO_IBE, 0);
|
|
sprd_gpio_update(chip, offset, SPRD_GPIO_IEV, 0);
|
|
sprd_gpio_update(chip, offset, SPRD_GPIO_IC, 1);
|
|
irq_set_handler_locked(data, handle_edge_irq);
|
|
break;
|
|
case IRQ_TYPE_EDGE_BOTH:
|
|
sprd_gpio_update(chip, offset, SPRD_GPIO_IS, 0);
|
|
sprd_gpio_update(chip, offset, SPRD_GPIO_IBE, 1);
|
|
sprd_gpio_update(chip, offset, SPRD_GPIO_IC, 1);
|
|
irq_set_handler_locked(data, handle_edge_irq);
|
|
break;
|
|
case IRQ_TYPE_LEVEL_HIGH:
|
|
sprd_gpio_update(chip, offset, SPRD_GPIO_IS, 1);
|
|
sprd_gpio_update(chip, offset, SPRD_GPIO_IBE, 0);
|
|
sprd_gpio_update(chip, offset, SPRD_GPIO_IEV, 1);
|
|
irq_set_handler_locked(data, handle_level_irq);
|
|
break;
|
|
case IRQ_TYPE_LEVEL_LOW:
|
|
sprd_gpio_update(chip, offset, SPRD_GPIO_IS, 1);
|
|
sprd_gpio_update(chip, offset, SPRD_GPIO_IBE, 0);
|
|
sprd_gpio_update(chip, offset, SPRD_GPIO_IEV, 0);
|
|
irq_set_handler_locked(data, handle_level_irq);
|
|
break;
|
|
default:
|
|
return -EINVAL;
|
|
}
|
|
|
|
return 0;
|
|
}
|
|
|
|
static void sprd_gpio_irq_handler(struct irq_desc *desc)
|
|
{
|
|
struct gpio_chip *chip = irq_desc_get_handler_data(desc);
|
|
struct irq_chip *ic = irq_desc_get_chip(desc);
|
|
struct sprd_gpio *sprd_gpio = gpiochip_get_data(chip);
|
|
u32 bank, n;
|
|
|
|
chained_irq_enter(ic, desc);
|
|
|
|
for (bank = 0; bank * SPRD_GPIO_BANK_NR < chip->ngpio; bank++) {
|
|
void __iomem *base = sprd_gpio_bank_base(sprd_gpio, bank);
|
|
unsigned long reg = readl_relaxed(base + SPRD_GPIO_MIS) &
|
|
SPRD_GPIO_BANK_MASK;
|
|
|
|
for_each_set_bit(n, ®, SPRD_GPIO_BANK_NR)
|
|
generic_handle_domain_irq(chip->irq.domain,
|
|
bank * SPRD_GPIO_BANK_NR + n);
|
|
}
|
|
chained_irq_exit(ic, desc);
|
|
}
|
|
|
|
static const struct irq_chip sprd_gpio_irqchip = {
|
|
.name = "sprd-gpio",
|
|
.irq_ack = sprd_gpio_irq_ack,
|
|
.irq_mask = sprd_gpio_irq_mask,
|
|
.irq_unmask = sprd_gpio_irq_unmask,
|
|
.irq_set_type = sprd_gpio_irq_set_type,
|
|
.flags = IRQCHIP_SKIP_SET_WAKE | IRQCHIP_IMMUTABLE,
|
|
GPIOCHIP_IRQ_RESOURCE_HELPERS,
|
|
};
|
|
|
|
static int sprd_gpio_probe(struct platform_device *pdev)
|
|
{
|
|
struct gpio_irq_chip *irq;
|
|
struct sprd_gpio *sprd_gpio;
|
|
|
|
sprd_gpio = devm_kzalloc(&pdev->dev, sizeof(*sprd_gpio), GFP_KERNEL);
|
|
if (!sprd_gpio)
|
|
return -ENOMEM;
|
|
|
|
sprd_gpio->irq = platform_get_irq(pdev, 0);
|
|
if (sprd_gpio->irq < 0)
|
|
return sprd_gpio->irq;
|
|
|
|
sprd_gpio->base = devm_platform_ioremap_resource(pdev, 0);
|
|
if (IS_ERR(sprd_gpio->base))
|
|
return PTR_ERR(sprd_gpio->base);
|
|
|
|
raw_spin_lock_init(&sprd_gpio->lock);
|
|
|
|
sprd_gpio->chip.label = dev_name(&pdev->dev);
|
|
sprd_gpio->chip.ngpio = SPRD_GPIO_NR;
|
|
sprd_gpio->chip.base = -1;
|
|
sprd_gpio->chip.parent = &pdev->dev;
|
|
sprd_gpio->chip.request = sprd_gpio_request;
|
|
sprd_gpio->chip.free = sprd_gpio_free;
|
|
sprd_gpio->chip.get = sprd_gpio_get;
|
|
sprd_gpio->chip.set = sprd_gpio_set;
|
|
sprd_gpio->chip.direction_input = sprd_gpio_direction_input;
|
|
sprd_gpio->chip.direction_output = sprd_gpio_direction_output;
|
|
|
|
irq = &sprd_gpio->chip.irq;
|
|
gpio_irq_chip_set_chip(irq, &sprd_gpio_irqchip);
|
|
irq->handler = handle_bad_irq;
|
|
irq->default_type = IRQ_TYPE_NONE;
|
|
irq->parent_handler = sprd_gpio_irq_handler;
|
|
irq->parent_handler_data = sprd_gpio;
|
|
irq->num_parents = 1;
|
|
irq->parents = &sprd_gpio->irq;
|
|
|
|
return devm_gpiochip_add_data(&pdev->dev, &sprd_gpio->chip, sprd_gpio);
|
|
}
|
|
|
|
static const struct of_device_id sprd_gpio_of_match[] = {
|
|
{ .compatible = "sprd,sc9860-gpio", },
|
|
{ /* end of list */ }
|
|
};
|
|
MODULE_DEVICE_TABLE(of, sprd_gpio_of_match);
|
|
|
|
static struct platform_driver sprd_gpio_driver = {
|
|
.probe = sprd_gpio_probe,
|
|
.driver = {
|
|
.name = "sprd-gpio",
|
|
.of_match_table = sprd_gpio_of_match,
|
|
},
|
|
};
|
|
|
|
module_platform_driver_probe(sprd_gpio_driver, sprd_gpio_probe);
|
|
|
|
MODULE_DESCRIPTION("Spreadtrum GPIO driver");
|
|
MODULE_LICENSE("GPL v2");
|