mirror of
https://github.com/torvalds/linux.git
synced 2026-03-08 04:04:43 +01:00
a047497f95
The frequency for an input reference is computed as: frequency = freq_base * freq_mult * freq_ratio_m / freq_ratio_n Before commit5bc02b190a("dpll: zl3073x: Cache all reference properties in zl3073x_ref"), zl3073x_dpll_input_pin_frequency_set() explicitly wrote 1 to both the REF_RATIO_M and REF_RATIO_N hardware registers whenever a new frequency was set. This ensured the FEC ratio was always reset to 1:1 alongside the new base/multiplier values. The refactoring in that commit introduced zl3073x_ref_freq_set() to update the cached ref state, but this helper only sets freq_base and freq_mult without resetting freq_ratio_m and freq_ratio_n to 1. Because zl3073x_ref_state_set() uses a compare-and-write strategy, unchanged ratio fields are never written to the hardware. If the device previously had non-unity FEC ratio values, they remain in effect after a frequency change, resulting in an incorrect computed frequency. Explicitly set freq_ratio_m and freq_ratio_n to 1 in zl3073x_ref_freq_set() to restore the original behavior. Fixes:5bc02b190a("dpll: zl3073x: Cache all reference properties in zl3073x_ref") Signed-off-by: Ivan Vecera <ivecera@redhat.com> Reviewed-by: Simon Horman <horms@kernel.org> Link: https://patch.msgid.link/20260216194007.680416-1-ivecera@redhat.com Signed-off-by: Jakub Kicinski <kuba@kernel.org>
136 lines
3.1 KiB
C
136 lines
3.1 KiB
C
/* SPDX-License-Identifier: GPL-2.0-only */
|
|
|
|
#ifndef _ZL3073X_REF_H
|
|
#define _ZL3073X_REF_H
|
|
|
|
#include <linux/bitfield.h>
|
|
#include <linux/math64.h>
|
|
#include <linux/types.h>
|
|
|
|
#include "regs.h"
|
|
|
|
struct zl3073x_dev;
|
|
|
|
/**
|
|
* struct zl3073x_ref - input reference state
|
|
* @ffo: current fractional frequency offset
|
|
* @phase_comp: phase compensation
|
|
* @esync_n_div: divisor for embedded sync or n-divided signal formats
|
|
* @freq_base: frequency base
|
|
* @freq_mult: frequnecy multiplier
|
|
* @freq_ratio_m: FEC mode multiplier
|
|
* @freq_ratio_n: FEC mode divisor
|
|
* @config: reference config
|
|
* @sync_ctrl: reference sync control
|
|
* @mon_status: reference monitor status
|
|
*/
|
|
struct zl3073x_ref {
|
|
s64 ffo;
|
|
u64 phase_comp;
|
|
u32 esync_n_div;
|
|
u16 freq_base;
|
|
u16 freq_mult;
|
|
u16 freq_ratio_m;
|
|
u16 freq_ratio_n;
|
|
u8 config;
|
|
u8 sync_ctrl;
|
|
u8 mon_status;
|
|
};
|
|
|
|
int zl3073x_ref_state_fetch(struct zl3073x_dev *zldev, u8 index);
|
|
|
|
const struct zl3073x_ref *zl3073x_ref_state_get(struct zl3073x_dev *zldev,
|
|
u8 index);
|
|
|
|
int zl3073x_ref_state_set(struct zl3073x_dev *zldev, u8 index,
|
|
const struct zl3073x_ref *ref);
|
|
|
|
int zl3073x_ref_freq_factorize(u32 freq, u16 *base, u16 *mult);
|
|
|
|
/**
|
|
* zl3073x_ref_ffo_get - get current fractional frequency offset
|
|
* @ref: pointer to ref state
|
|
*
|
|
* Return: the latest measured fractional frequency offset
|
|
*/
|
|
static inline s64
|
|
zl3073x_ref_ffo_get(const struct zl3073x_ref *ref)
|
|
{
|
|
return ref->ffo;
|
|
}
|
|
|
|
/**
|
|
* zl3073x_ref_freq_get - get given input reference frequency
|
|
* @ref: pointer to ref state
|
|
*
|
|
* Return: frequency of the given input reference
|
|
*/
|
|
static inline u32
|
|
zl3073x_ref_freq_get(const struct zl3073x_ref *ref)
|
|
{
|
|
return mul_u64_u32_div(ref->freq_base * ref->freq_mult,
|
|
ref->freq_ratio_m, ref->freq_ratio_n);
|
|
}
|
|
|
|
/**
|
|
* zl3073x_ref_freq_set - set given input reference frequency
|
|
* @ref: pointer to ref state
|
|
* @freq: frequency to be set
|
|
*
|
|
* Return: 0 on success, <0 when frequency cannot be factorized
|
|
*/
|
|
static inline int
|
|
zl3073x_ref_freq_set(struct zl3073x_ref *ref, u32 freq)
|
|
{
|
|
u16 base, mult;
|
|
int rc;
|
|
|
|
rc = zl3073x_ref_freq_factorize(freq, &base, &mult);
|
|
if (rc)
|
|
return rc;
|
|
|
|
ref->freq_base = base;
|
|
ref->freq_mult = mult;
|
|
ref->freq_ratio_m = 1;
|
|
ref->freq_ratio_n = 1;
|
|
|
|
return 0;
|
|
}
|
|
|
|
/**
|
|
* zl3073x_ref_is_diff - check if the given input reference is differential
|
|
* @ref: pointer to ref state
|
|
*
|
|
* Return: true if reference is differential, false if reference is single-ended
|
|
*/
|
|
static inline bool
|
|
zl3073x_ref_is_diff(const struct zl3073x_ref *ref)
|
|
{
|
|
return !!FIELD_GET(ZL_REF_CONFIG_DIFF_EN, ref->config);
|
|
}
|
|
|
|
/**
|
|
* zl3073x_ref_is_enabled - check if the given input reference is enabled
|
|
* @ref: pointer to ref state
|
|
*
|
|
* Return: true if input refernce is enabled, false otherwise
|
|
*/
|
|
static inline bool
|
|
zl3073x_ref_is_enabled(const struct zl3073x_ref *ref)
|
|
{
|
|
return !!FIELD_GET(ZL_REF_CONFIG_ENABLE, ref->config);
|
|
}
|
|
|
|
/**
|
|
* zl3073x_ref_is_status_ok - check the given input reference status
|
|
* @ref: pointer to ref state
|
|
*
|
|
* Return: true if the status is ok, false otherwise
|
|
*/
|
|
static inline bool
|
|
zl3073x_ref_is_status_ok(const struct zl3073x_ref *ref)
|
|
{
|
|
return ref->mon_status == ZL_REF_MON_STATUS_OK;
|
|
}
|
|
|
|
#endif /* _ZL3073X_REF_H */
|