mirror of
https://github.com/torvalds/linux.git
synced 2026-03-08 03:04:51 +01:00
Lock debugging:
- Implement compiler-driven static analysis locking context
checking, using the upcoming Clang 22 compiler's context
analysis features. (Marco Elver)
We removed Sparse context analysis support, because prior to
removal even a defconfig kernel produced 1,700+ context
tracking Sparse warnings, the overwhelming majority of which
are false positives. On an allmodconfig kernel the number of
false positive context tracking Sparse warnings grows to
over 5,200... On the plus side of the balance actual locking
bugs found by Sparse context analysis is also rather ... sparse:
I found only 3 such commits in the last 3 years. So the
rate of false positives and the maintenance overhead is
rather high and there appears to be no active policy in
place to achieve a zero-warnings baseline to move the
annotations & fixers to developers who introduce new code.
Clang context analysis is more complete and more aggressive
in trying to find bugs, at least in principle. Plus it has
a different model to enabling it: it's enabled subsystem by
subsystem, which results in zero warnings on all relevant
kernel builds (as far as our testing managed to cover it).
Which allowed us to enable it by default, similar to other
compiler warnings, with the expectation that there are no
warnings going forward. This enforces a zero-warnings baseline
on clang-22+ builds. (Which are still limited in distribution,
admittedly.)
Hopefully the Clang approach can lead to a more maintainable
zero-warnings status quo and policy, with more and more
subsystems and drivers enabling the feature. Context tracking
can be enabled for all kernel code via WARN_CONTEXT_ANALYSIS_ALL=y
(default disabled), but this will generate a lot of false positives.
( Having said that, Sparse support could still be added back,
if anyone is interested - the removal patch is still
relatively straightforward to revert at this stage. )
Rust integration updates: (Alice Ryhl, Fujita Tomonori, Boqun Feng)
- Add support for Atomic<i8/i16/bool> and replace most Rust native
AtomicBool usages with Atomic<bool>
- Clean up LockClassKey and improve its documentation
- Add missing Send and Sync trait implementation for SetOnce
- Make ARef Unpin as it is supposed to be
- Add __rust_helper to a few Rust helpers as a preparation for
helper LTO
- Inline various lock related functions to avoid additional
function calls.
WW mutexes:
- Extend ww_mutex tests and other test-ww_mutex updates (John Stultz)
Misc fixes and cleanups:
- rcu: Mark lockdep_assert_rcu_helper() __always_inline
(Arnd Bergmann)
- locking/local_lock: Include more missing headers (Peter Zijlstra)
- seqlock: fix scoped_seqlock_read kernel-doc (Randy Dunlap)
- rust: sync: Replace `kernel::c_str!` with C-Strings
(Tamir Duberstein)
Signed-off-by: Ingo Molnar <mingo@kernel.org>
-----BEGIN PGP SIGNATURE-----
iQJFBAABCgAvFiEEBpT5eoXrXCwVQwEKEnMQ0APhK1gFAmmIXiURHG1pbmdvQGtl
cm5lbC5vcmcACgkQEnMQ0APhK1gH+A/9GX5UmU6+HuDfDrCtXm9GDve6wkwahvcW
jLDxOYjs764I2BhyjZnjKjyF5zw60hbykem7Wcf5EV2YH30nM4XRgEWVJfkr1UAI
Pra415X4DdOzZ6qYQIpO8Udt1LtR7BMSaXITVLJaLicxEoOVtq3SKxjqyhCFs7UW
MfJdqleB+RMLqq3LlzgB4l43eKk1xyeHh+oQwI0RSxuIpVZme3p4TObnCKjIWnK7
Ihd+dkgC852WBjANgNL7F/sd5UsF5QX3wjtOrLhMKvkIgTPdXln0g398pivjN/G/
Kpnw18SFeb159JfJu8eMotsYvVnQ0D5aOcTBfL4qvOHCImhpcu2s6ik9BcXqt2yT
8IiuWk9xEM3Ok+I/I4ClT5cf5GYpyigV2QsXxn+IjDX5Na8v4zlHh0r8SElP8fOt
7dpQx7iw8UghAib3AzA3suN78Oh39m8l5BNobj7LAjnqOQcVvoPo4o7/48ntuH7A
38EucFrXfxQBMfGbMwvxEmgYuX7MyVfQLaPE06MHy1BkZkffT8Um38TB0iNtZmtf
WUx01yLKWYspehlwFi319uVI4/Zp7FnTfqa5uKv1oSXVdL9vZojSXUzrgDV7FVqT
Z4xAAw/kwNHpUG7y0zNOqd6PukovG1t+CjbLvK+eHPwc5c0vEGG2oTRAfEvvP1z/
kesYDmCyJnk=
=N1gA
-----END PGP SIGNATURE-----
Merge tag 'locking-core-2026-02-08' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip
Pull locking updates from Ingo Molnar:
"Lock debugging:
- Implement compiler-driven static analysis locking context checking,
using the upcoming Clang 22 compiler's context analysis features
(Marco Elver)
We removed Sparse context analysis support, because prior to
removal even a defconfig kernel produced 1,700+ context tracking
Sparse warnings, the overwhelming majority of which are false
positives. On an allmodconfig kernel the number of false positive
context tracking Sparse warnings grows to over 5,200... On the plus
side of the balance actual locking bugs found by Sparse context
analysis is also rather ... sparse: I found only 3 such commits in
the last 3 years. So the rate of false positives and the
maintenance overhead is rather high and there appears to be no
active policy in place to achieve a zero-warnings baseline to move
the annotations & fixers to developers who introduce new code.
Clang context analysis is more complete and more aggressive in
trying to find bugs, at least in principle. Plus it has a different
model to enabling it: it's enabled subsystem by subsystem, which
results in zero warnings on all relevant kernel builds (as far as
our testing managed to cover it). Which allowed us to enable it by
default, similar to other compiler warnings, with the expectation
that there are no warnings going forward. This enforces a
zero-warnings baseline on clang-22+ builds (Which are still limited
in distribution, admittedly)
Hopefully the Clang approach can lead to a more maintainable
zero-warnings status quo and policy, with more and more subsystems
and drivers enabling the feature. Context tracking can be enabled
for all kernel code via WARN_CONTEXT_ANALYSIS_ALL=y (default
disabled), but this will generate a lot of false positives.
( Having said that, Sparse support could still be added back,
if anyone is interested - the removal patch is still
relatively straightforward to revert at this stage. )
Rust integration updates: (Alice Ryhl, Fujita Tomonori, Boqun Feng)
- Add support for Atomic<i8/i16/bool> and replace most Rust native
AtomicBool usages with Atomic<bool>
- Clean up LockClassKey and improve its documentation
- Add missing Send and Sync trait implementation for SetOnce
- Make ARef Unpin as it is supposed to be
- Add __rust_helper to a few Rust helpers as a preparation for
helper LTO
- Inline various lock related functions to avoid additional function
calls
WW mutexes:
- Extend ww_mutex tests and other test-ww_mutex updates (John
Stultz)
Misc fixes and cleanups:
- rcu: Mark lockdep_assert_rcu_helper() __always_inline (Arnd
Bergmann)
- locking/local_lock: Include more missing headers (Peter Zijlstra)
- seqlock: fix scoped_seqlock_read kernel-doc (Randy Dunlap)
- rust: sync: Replace `kernel::c_str!` with C-Strings (Tamir
Duberstein)"
* tag 'locking-core-2026-02-08' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip: (90 commits)
locking/rwlock: Fix write_trylock_irqsave() with CONFIG_INLINE_WRITE_TRYLOCK
rcu: Mark lockdep_assert_rcu_helper() __always_inline
compiler-context-analysis: Remove __assume_ctx_lock from initializers
tomoyo: Use scoped init guard
crypto: Use scoped init guard
kcov: Use scoped init guard
compiler-context-analysis: Introduce scoped init guards
cleanup: Make __DEFINE_LOCK_GUARD handle commas in initializers
seqlock: fix scoped_seqlock_read kernel-doc
tools: Update context analysis macros in compiler_types.h
rust: sync: Replace `kernel::c_str!` with C-Strings
rust: sync: Inline various lock related methods
rust: helpers: Move #define __rust_helper out of atomic.c
rust: wait: Add __rust_helper to helpers
rust: time: Add __rust_helper to helpers
rust: task: Add __rust_helper to helpers
rust: sync: Add __rust_helper to helpers
rust: refcount: Add __rust_helper to helpers
rust: rcu: Add __rust_helper to helpers
rust: processor: Add __rust_helper to helpers
...
404 lines
9.2 KiB
C
404 lines
9.2 KiB
C
// SPDX-License-Identifier: GPL-2.0-or-later
|
|
/*
|
|
* Synchronous Compression operations
|
|
*
|
|
* Copyright 2015 LG Electronics Inc.
|
|
* Copyright (c) 2016, Intel Corporation
|
|
* Author: Giovanni Cabiddu <giovanni.cabiddu@intel.com>
|
|
*/
|
|
|
|
#include <crypto/internal/scompress.h>
|
|
#include <crypto/scatterwalk.h>
|
|
#include <linux/cpumask.h>
|
|
#include <linux/cryptouser.h>
|
|
#include <linux/err.h>
|
|
#include <linux/highmem.h>
|
|
#include <linux/kernel.h>
|
|
#include <linux/module.h>
|
|
#include <linux/overflow.h>
|
|
#include <linux/scatterlist.h>
|
|
#include <linux/seq_file.h>
|
|
#include <linux/slab.h>
|
|
#include <linux/string.h>
|
|
#include <linux/workqueue.h>
|
|
#include <net/netlink.h>
|
|
|
|
#include "compress.h"
|
|
|
|
struct scomp_scratch {
|
|
spinlock_t lock;
|
|
union {
|
|
void *src __guarded_by(&lock);
|
|
unsigned long saddr __guarded_by(&lock);
|
|
};
|
|
};
|
|
|
|
static DEFINE_PER_CPU(struct scomp_scratch, scomp_scratch) = {
|
|
.lock = __SPIN_LOCK_UNLOCKED(scomp_scratch.lock),
|
|
};
|
|
|
|
static const struct crypto_type crypto_scomp_type;
|
|
static DEFINE_MUTEX(scomp_lock);
|
|
static int scomp_scratch_users __guarded_by(&scomp_lock);
|
|
|
|
static cpumask_t scomp_scratch_want;
|
|
static void scomp_scratch_workfn(struct work_struct *work);
|
|
static DECLARE_WORK(scomp_scratch_work, scomp_scratch_workfn);
|
|
|
|
static int __maybe_unused crypto_scomp_report(
|
|
struct sk_buff *skb, struct crypto_alg *alg)
|
|
{
|
|
struct crypto_report_comp rscomp;
|
|
|
|
memset(&rscomp, 0, sizeof(rscomp));
|
|
|
|
strscpy(rscomp.type, "scomp", sizeof(rscomp.type));
|
|
|
|
return nla_put(skb, CRYPTOCFGA_REPORT_COMPRESS,
|
|
sizeof(rscomp), &rscomp);
|
|
}
|
|
|
|
static void __maybe_unused crypto_scomp_show(struct seq_file *m,
|
|
struct crypto_alg *alg)
|
|
{
|
|
seq_puts(m, "type : scomp\n");
|
|
}
|
|
|
|
static void crypto_scomp_free_scratches(void)
|
|
__context_unsafe(/* frees @scratch */)
|
|
{
|
|
struct scomp_scratch *scratch;
|
|
int i;
|
|
|
|
for_each_possible_cpu(i) {
|
|
scratch = per_cpu_ptr(&scomp_scratch, i);
|
|
|
|
free_page(scratch->saddr);
|
|
scratch->src = NULL;
|
|
}
|
|
}
|
|
|
|
static int scomp_alloc_scratch(struct scomp_scratch *scratch, int cpu)
|
|
{
|
|
int node = cpu_to_node(cpu);
|
|
struct page *page;
|
|
|
|
page = alloc_pages_node(node, GFP_KERNEL, 0);
|
|
if (!page)
|
|
return -ENOMEM;
|
|
spin_lock_bh(&scratch->lock);
|
|
scratch->src = page_address(page);
|
|
spin_unlock_bh(&scratch->lock);
|
|
return 0;
|
|
}
|
|
|
|
static void scomp_scratch_workfn(struct work_struct *work)
|
|
{
|
|
int cpu;
|
|
|
|
for_each_cpu(cpu, &scomp_scratch_want) {
|
|
struct scomp_scratch *scratch;
|
|
|
|
scratch = per_cpu_ptr(&scomp_scratch, cpu);
|
|
if (context_unsafe(scratch->src))
|
|
continue;
|
|
if (scomp_alloc_scratch(scratch, cpu))
|
|
break;
|
|
|
|
cpumask_clear_cpu(cpu, &scomp_scratch_want);
|
|
}
|
|
}
|
|
|
|
static int crypto_scomp_alloc_scratches(void)
|
|
__context_unsafe(/* allocates @scratch */)
|
|
{
|
|
unsigned int i = cpumask_first(cpu_possible_mask);
|
|
struct scomp_scratch *scratch;
|
|
|
|
scratch = per_cpu_ptr(&scomp_scratch, i);
|
|
return scomp_alloc_scratch(scratch, i);
|
|
}
|
|
|
|
static int crypto_scomp_init_tfm(struct crypto_tfm *tfm)
|
|
{
|
|
struct scomp_alg *alg = crypto_scomp_alg(__crypto_scomp_tfm(tfm));
|
|
int ret = 0;
|
|
|
|
mutex_lock(&scomp_lock);
|
|
ret = crypto_acomp_alloc_streams(&alg->streams);
|
|
if (ret)
|
|
goto unlock;
|
|
if (!scomp_scratch_users++) {
|
|
ret = crypto_scomp_alloc_scratches();
|
|
if (ret)
|
|
scomp_scratch_users--;
|
|
}
|
|
unlock:
|
|
mutex_unlock(&scomp_lock);
|
|
|
|
return ret;
|
|
}
|
|
|
|
#define scomp_lock_scratch(...) __acquire_ret(_scomp_lock_scratch(__VA_ARGS__), &__ret->lock)
|
|
static struct scomp_scratch *_scomp_lock_scratch(void) __acquires_ret
|
|
{
|
|
int cpu = raw_smp_processor_id();
|
|
struct scomp_scratch *scratch;
|
|
|
|
scratch = per_cpu_ptr(&scomp_scratch, cpu);
|
|
spin_lock(&scratch->lock);
|
|
if (likely(scratch->src))
|
|
return scratch;
|
|
spin_unlock(&scratch->lock);
|
|
|
|
cpumask_set_cpu(cpu, &scomp_scratch_want);
|
|
schedule_work(&scomp_scratch_work);
|
|
|
|
scratch = per_cpu_ptr(&scomp_scratch, cpumask_first(cpu_possible_mask));
|
|
spin_lock(&scratch->lock);
|
|
return scratch;
|
|
}
|
|
|
|
static inline void scomp_unlock_scratch(struct scomp_scratch *scratch)
|
|
__releases(&scratch->lock)
|
|
{
|
|
spin_unlock(&scratch->lock);
|
|
}
|
|
|
|
static int scomp_acomp_comp_decomp(struct acomp_req *req, int dir)
|
|
{
|
|
struct crypto_acomp *tfm = crypto_acomp_reqtfm(req);
|
|
struct crypto_scomp **tfm_ctx = acomp_tfm_ctx(tfm);
|
|
bool src_isvirt = acomp_request_src_isvirt(req);
|
|
bool dst_isvirt = acomp_request_dst_isvirt(req);
|
|
struct crypto_scomp *scomp = *tfm_ctx;
|
|
unsigned int slen = req->slen;
|
|
unsigned int dlen = req->dlen;
|
|
struct page *spage, *dpage;
|
|
unsigned int n;
|
|
const u8 *src;
|
|
size_t soff;
|
|
size_t doff;
|
|
u8 *dst;
|
|
int ret;
|
|
|
|
if (!req->src || !slen)
|
|
return -EINVAL;
|
|
|
|
if (!req->dst || !dlen)
|
|
return -EINVAL;
|
|
|
|
if (dst_isvirt)
|
|
dst = req->dvirt;
|
|
else {
|
|
if (dlen <= req->dst->length) {
|
|
dpage = sg_page(req->dst);
|
|
doff = req->dst->offset;
|
|
} else
|
|
return -ENOSYS;
|
|
|
|
dpage += doff / PAGE_SIZE;
|
|
doff = offset_in_page(doff);
|
|
|
|
n = (dlen - 1) / PAGE_SIZE;
|
|
n += (offset_in_page(dlen - 1) + doff) / PAGE_SIZE;
|
|
if (PageHighMem(dpage + n) &&
|
|
size_add(doff, dlen) > PAGE_SIZE)
|
|
return -ENOSYS;
|
|
dst = kmap_local_page(dpage) + doff;
|
|
}
|
|
|
|
if (src_isvirt)
|
|
src = req->svirt;
|
|
else {
|
|
src = NULL;
|
|
do {
|
|
if (slen <= req->src->length) {
|
|
spage = sg_page(req->src);
|
|
soff = req->src->offset;
|
|
} else
|
|
break;
|
|
|
|
spage = spage + soff / PAGE_SIZE;
|
|
soff = offset_in_page(soff);
|
|
|
|
n = (slen - 1) / PAGE_SIZE;
|
|
n += (offset_in_page(slen - 1) + soff) / PAGE_SIZE;
|
|
if (PageHighMem(spage + n) &&
|
|
size_add(soff, slen) > PAGE_SIZE)
|
|
break;
|
|
src = kmap_local_page(spage) + soff;
|
|
} while (0);
|
|
}
|
|
|
|
struct crypto_acomp_stream *stream = crypto_acomp_lock_stream_bh(&crypto_scomp_alg(scomp)->streams);
|
|
|
|
if (!src_isvirt && !src) {
|
|
struct scomp_scratch *scratch = scomp_lock_scratch();
|
|
const u8 *src = scratch->src;
|
|
|
|
memcpy_from_sglist(scratch->src, req->src, 0, slen);
|
|
|
|
if (dir)
|
|
ret = crypto_scomp_compress(scomp, src, slen,
|
|
dst, &dlen, stream->ctx);
|
|
else
|
|
ret = crypto_scomp_decompress(scomp, src, slen,
|
|
dst, &dlen, stream->ctx);
|
|
|
|
scomp_unlock_scratch(scratch);
|
|
} else if (dir)
|
|
ret = crypto_scomp_compress(scomp, src, slen,
|
|
dst, &dlen, stream->ctx);
|
|
else
|
|
ret = crypto_scomp_decompress(scomp, src, slen,
|
|
dst, &dlen, stream->ctx);
|
|
|
|
crypto_acomp_unlock_stream_bh(stream);
|
|
|
|
req->dlen = dlen;
|
|
|
|
if (!src_isvirt && src)
|
|
kunmap_local(src);
|
|
if (!dst_isvirt) {
|
|
kunmap_local(dst);
|
|
dlen += doff;
|
|
for (;;) {
|
|
flush_dcache_page(dpage);
|
|
if (dlen <= PAGE_SIZE)
|
|
break;
|
|
dlen -= PAGE_SIZE;
|
|
dpage++;
|
|
}
|
|
}
|
|
|
|
return ret;
|
|
}
|
|
|
|
static int scomp_acomp_compress(struct acomp_req *req)
|
|
{
|
|
return scomp_acomp_comp_decomp(req, 1);
|
|
}
|
|
|
|
static int scomp_acomp_decompress(struct acomp_req *req)
|
|
{
|
|
return scomp_acomp_comp_decomp(req, 0);
|
|
}
|
|
|
|
static void crypto_exit_scomp_ops_async(struct crypto_tfm *tfm)
|
|
{
|
|
struct crypto_scomp **ctx = crypto_tfm_ctx(tfm);
|
|
|
|
crypto_free_scomp(*ctx);
|
|
|
|
flush_work(&scomp_scratch_work);
|
|
mutex_lock(&scomp_lock);
|
|
if (!--scomp_scratch_users)
|
|
crypto_scomp_free_scratches();
|
|
mutex_unlock(&scomp_lock);
|
|
}
|
|
|
|
int crypto_init_scomp_ops_async(struct crypto_tfm *tfm)
|
|
{
|
|
struct crypto_alg *calg = tfm->__crt_alg;
|
|
struct crypto_acomp *crt = __crypto_acomp_tfm(tfm);
|
|
struct crypto_scomp **ctx = crypto_tfm_ctx(tfm);
|
|
struct crypto_scomp *scomp;
|
|
|
|
if (!crypto_mod_get(calg))
|
|
return -EAGAIN;
|
|
|
|
scomp = crypto_create_tfm(calg, &crypto_scomp_type);
|
|
if (IS_ERR(scomp)) {
|
|
crypto_mod_put(calg);
|
|
return PTR_ERR(scomp);
|
|
}
|
|
|
|
*ctx = scomp;
|
|
tfm->exit = crypto_exit_scomp_ops_async;
|
|
|
|
crt->compress = scomp_acomp_compress;
|
|
crt->decompress = scomp_acomp_decompress;
|
|
|
|
return 0;
|
|
}
|
|
|
|
static void crypto_scomp_destroy(struct crypto_alg *alg)
|
|
{
|
|
struct scomp_alg *scomp = __crypto_scomp_alg(alg);
|
|
|
|
crypto_acomp_free_streams(&scomp->streams);
|
|
}
|
|
|
|
static const struct crypto_type crypto_scomp_type = {
|
|
.extsize = crypto_alg_extsize,
|
|
.init_tfm = crypto_scomp_init_tfm,
|
|
.destroy = crypto_scomp_destroy,
|
|
#ifdef CONFIG_PROC_FS
|
|
.show = crypto_scomp_show,
|
|
#endif
|
|
#if IS_ENABLED(CONFIG_CRYPTO_USER)
|
|
.report = crypto_scomp_report,
|
|
#endif
|
|
.maskclear = ~CRYPTO_ALG_TYPE_MASK,
|
|
.maskset = CRYPTO_ALG_TYPE_MASK,
|
|
.type = CRYPTO_ALG_TYPE_SCOMPRESS,
|
|
.tfmsize = offsetof(struct crypto_scomp, base),
|
|
.algsize = offsetof(struct scomp_alg, base),
|
|
};
|
|
|
|
static void scomp_prepare_alg(struct scomp_alg *alg)
|
|
{
|
|
struct crypto_alg *base = &alg->calg.base;
|
|
|
|
comp_prepare_alg(&alg->calg);
|
|
|
|
base->cra_flags |= CRYPTO_ALG_REQ_VIRT;
|
|
}
|
|
|
|
int crypto_register_scomp(struct scomp_alg *alg)
|
|
{
|
|
struct crypto_alg *base = &alg->calg.base;
|
|
|
|
scomp_prepare_alg(alg);
|
|
|
|
base->cra_type = &crypto_scomp_type;
|
|
base->cra_flags |= CRYPTO_ALG_TYPE_SCOMPRESS;
|
|
|
|
return crypto_register_alg(base);
|
|
}
|
|
EXPORT_SYMBOL_GPL(crypto_register_scomp);
|
|
|
|
void crypto_unregister_scomp(struct scomp_alg *alg)
|
|
{
|
|
crypto_unregister_alg(&alg->base);
|
|
}
|
|
EXPORT_SYMBOL_GPL(crypto_unregister_scomp);
|
|
|
|
int crypto_register_scomps(struct scomp_alg *algs, int count)
|
|
{
|
|
int i, ret;
|
|
|
|
for (i = 0; i < count; i++) {
|
|
ret = crypto_register_scomp(&algs[i]);
|
|
if (ret) {
|
|
crypto_unregister_scomps(algs, i);
|
|
return ret;
|
|
}
|
|
}
|
|
|
|
return 0;
|
|
}
|
|
EXPORT_SYMBOL_GPL(crypto_register_scomps);
|
|
|
|
void crypto_unregister_scomps(struct scomp_alg *algs, int count)
|
|
{
|
|
int i;
|
|
|
|
for (i = count - 1; i >= 0; --i)
|
|
crypto_unregister_scomp(&algs[i]);
|
|
}
|
|
EXPORT_SYMBOL_GPL(crypto_unregister_scomps);
|
|
|
|
MODULE_LICENSE("GPL");
|
|
MODULE_DESCRIPTION("Synchronous compression type");
|