archives/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-03-08 03:24:45 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

ASoC: soc-core: check ops & auto_selectable_formats in snd_soc_dai_get_fmt() to prevent dereference error

Browse source 
Smatch reported an issue that "ops" could be null (see
line 174) where later "ops" is dereferenced to extract
the dai fmts, also auto_selectable_formats can also be
null.

Add a proper null check before accessing both the ptrs
to ensure a safe execution.

Signed-off-by: HariKrishna Sagala <hariconscious@gmail.com>
Link: https://patch.msgid.link/20251030105313.32199-2-hariconscious@gmail.com
Signed-off-by: Mark Brown <broonie@kernel.org>
This commit is contained in:
HariKrishna Sagala 2025-10-30 16:23:14 +05:30 • committed by Mark Brown
parent 6ef8e042cd
commit e73b743bfe
No known key found for this signature in database
GPG key ID: 24D68B725D5487D0
1 changed files with 3 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

5
sound/soc/soc-dai.c
View file

@ -177,8 +177,9 @@ u64 snd_soc_dai_get_fmt(const struct snd_soc_dai *dai, int priority)
if (max < until)
until = max;
for (i = 0; i < until; i++)
fmt |= ops->auto_selectable_formats[i];
if (ops && ops->auto_selectable_formats)
for (i = 0; i < until; i++)
fmt |= ops->auto_selectable_formats[i];
return fmt;
}