archives/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-03-08 04:04:43 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

phy: phy-can-transceiver: Drop the gpio desc check

Browse source 
gpiod_set_value_cansleep has an internal check on gpio_desc using
'VALIDATE_DESC(desc)', the check before invoking gpiod_set_value_cansleep
could be removed.

Reviewed-by: Frank Li <Frank.Li@nxp.com>
Signed-off-by: Peng Fan <peng.fan@nxp.com>
Acked-by: Marc Kleine-Budde <mkl@pengutronix.de>
Link: https://patch.msgid.link/20251001-can-v7-4-fad29efc3884@nxp.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
This commit is contained in:
Peng Fan 2025-10-01 21:22:35 +08:00 • committed by Vinod Koul
parent 6e9fe9409e
commit d02a7eb129
1 changed files with 4 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

12
drivers/phy/phy-can-transceiver.c
View file

@ -47,10 +47,8 @@ static int can_transceiver_phy_power_on(struct phy *phy)
return ret;
}
}
if (can_transceiver_phy->standby_gpio)
gpiod_set_value_cansleep(can_transceiver_phy->standby_gpio, 0);
if (can_transceiver_phy->enable_gpio)
gpiod_set_value_cansleep(can_transceiver_phy->enable_gpio, 1);
gpiod_set_value_cansleep(can_transceiver_phy->standby_gpio, 0);
gpiod_set_value_cansleep(can_transceiver_phy->enable_gpio, 1);
return 0;
}
@ -61,10 +59,8 @@ static int can_transceiver_phy_power_off(struct phy *phy)
struct can_transceiver_phy *can_transceiver_phy = phy_get_drvdata(phy);
struct can_transceiver_priv *priv = can_transceiver_phy->priv;
if (can_transceiver_phy->standby_gpio)
gpiod_set_value_cansleep(can_transceiver_phy->standby_gpio, 1);
if (can_transceiver_phy->enable_gpio)
gpiod_set_value_cansleep(can_transceiver_phy->enable_gpio, 0);
gpiod_set_value_cansleep(can_transceiver_phy->standby_gpio, 1);
gpiod_set_value_cansleep(can_transceiver_phy->enable_gpio, 0);
if (priv->mux_state)
mux_state_deselect(priv->mux_state);