archives/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-03-13 22:36:17 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

ASoC: codec: rt274: Use devm_request_threaded_irq to manage IRQ lifetime and fix smatch warning

Browse source 
Replace manual "request_threaded_irq()" with the device managed
"devm_request_threaded_irq" to manage the IRQ lifetime and also
it removes the smatch reported warning.
Remove the manual "free_irq()" in the "remove" function as free_irq
is tied to device teardown.

Signed-off-by: HariKrishna Sagala <hariconscious@gmail.com>
Link: https://patch.msgid.link/20251121140940.40678-4-hariconscious@gmail.com
Signed-off-by: Mark Brown <broonie@kernel.org>
This commit is contained in:
HariKrishna Sagala 2025-11-21 19:39:43 +05:30 • committed by Mark Brown
parent 774d075a80
commit d00e80606e
No known key found for this signature in database
GPG key ID: 24D68B725D5487D0
1 changed files with 1 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

12
sound/soc/codecs/rt274.c
View file

@ -1189,7 +1189,7 @@ static int rt274_i2c_probe(struct i2c_client *i2c)
regmap_write(rt274->regmap, RT274_UNSOLICITED_MIC, 0x82);
if (rt274->i2c->irq) {
ret = request_threaded_irq(rt274->i2c->irq, NULL, rt274_irq,
ret = devm_request_threaded_irq(&rt274->i2c->dev, rt274->i2c->irq, NULL, rt274_irq,
IRQF_TRIGGER_HIGH | IRQF_ONESHOT, "rt274", rt274);
if (ret != 0) {
dev_err(&i2c->dev,
@ -1205,15 +1205,6 @@ static int rt274_i2c_probe(struct i2c_client *i2c)
return ret;
}
static void rt274_i2c_remove(struct i2c_client *i2c)
{
struct rt274_priv *rt274 = i2c_get_clientdata(i2c);
if (i2c->irq)
free_irq(i2c->irq, rt274);
}
static struct i2c_driver rt274_i2c_driver = {
.driver = {
.name = "rt274",
@ -1223,7 +1214,6 @@ static struct i2c_driver rt274_i2c_driver = {
#endif
},
.probe = rt274_i2c_probe,
.remove = rt274_i2c_remove,
.id_table = rt274_i2c_id,
};