archives/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-03-08 04:04:43 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

media: i2c: imx208: Use V4L2 sensor clock helper

Browse source 
Several camera sensor drivers access the "clock-frequency" property
directly to retrieve the external clock rate, or modify the clock rate
of the external clock programmatically. Both behaviours are valid on
a subset of ACPI platforms, but are considered deprecated on OF
platforms, and do not support ACPI platforms that implement MIPI DisCo
for Imaging. Implementing them manually in drivers is deprecated, as
that can encourage cargo-cult and lead to differences in behaviour
between drivers. Instead, drivers should use the
devm_v4l2_sensor_clk_get() helper.

This driver supports ACPI platforms only. It retrieves the clock rate
from the "clock-frequency" property. If the rate does not match the
expected rate, the driver fails probing. This is correct behaviour for
ACPI.

Switch to using the devm_v4l2_sensor_clk_get() helper. This does not
change the behaviour on ACPI platforms that specify a clock-frequency
property and don't provide a clock. On ACPI platforms that provide a
clock, the clock rate will be set to the value of the clock-frequency
property. This should not change the behaviour either as this driver
expects the clock to be set to that rate, and wouldn't operate correctly
otherwise.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Reviewed-by: Mehdi Djait <mehdi.djait@linux.intel.com>
Signed-off-by: Hans Verkuil <hverkuil+cisco@kernel.org>
This commit is contained in:
Laurent Pinchart 2025-08-13 00:45:23 +03:00 • committed by Mauro Carvalho Chehab
parent 5fa4f8665f
commit cff416364c
1 changed files with 14 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

23
drivers/media/i2c/imx208.c
View file

@ -2,6 +2,7 @@
// Copyright (C) 2021 Intel Corporation
#include <linux/acpi.h>
#include <linux/clk.h>
#include <linux/delay.h>
#include <linux/i2c.h>
#include <linux/module.h>
@ -270,6 +271,7 @@ static const struct imx208_mode supported_modes[] = {
struct imx208 {
struct device *dev;
struct clk *clk;
struct v4l2_subdev sd;
struct media_pad pad;
@ -934,17 +936,9 @@ static void imx208_free_controls(struct imx208 *imx208)
static int imx208_probe(struct i2c_client *client)
{
struct imx208 *imx208;
unsigned long freq;
int ret;
bool full_power;
u32 val = 0;
device_property_read_u32(&client->dev, "clock-frequency", &val);
if (val != 19200000) {
dev_err(&client->dev,
"Unsupported clock-frequency %u. Expected 19200000.\n",
val);
return -EINVAL;
}
imx208 = devm_kzalloc(&client->dev, sizeof(*imx208), GFP_KERNEL);
if (!imx208)
@ -952,6 +946,17 @@ static int imx208_probe(struct i2c_client *client)
imx208->dev = &client->dev;
imx208->clk = devm_v4l2_sensor_clk_get(imx208->dev, NULL);
if (IS_ERR(imx208->clk))
return dev_err_probe(imx208->dev, PTR_ERR(imx208->clk),
"failed to get clock\n");
freq = clk_get_rate(imx208->clk);
if (freq != 19200000)
return dev_err_probe(imx208->dev, -EINVAL,
"external clock %lu is not supported\n",
freq);
/* Initialize subdev */
v4l2_i2c_subdev_init(&imx208->sd, client, &imx208_subdev_ops);