archives/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-03-08 02:24:32 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

RDMA/rxe: switch to using the crc32 library

Browse source 
Now that the crc32_le() library function takes advantage of
architecture-specific optimizations, it is unnecessary to go through the
crypto API.  Just use crc32_le().  This is much simpler, and it improves
performance due to eliminating the crypto API overhead.

Signed-off-by: Eric Biggers <ebiggers@google.com>
Link: https://patch.msgid.link/20250207032316.53941-1-ebiggers@kernel.org
Reviewed-by: Zhu Yanjun <yanjun.zhu@linux.dev>
Signed-off-by: Leon Romanovsky <leon@kernel.org>
This commit is contained in:
Eric Biggers 2025-02-06 19:23:16 -08:00 • committed by Leon Romanovsky
parent 79bccd7461
commit ccca5e8aa1
8 changed files with 2 additions and 52 deletions
Download patch file Download diff file Expand all files Collapse all files

3
drivers/infiniband/sw/rxe/Kconfig
View file

@ -4,8 +4,7 @@ config RDMA_RXE
depends on INET && PCI && INFINIBAND
depends on INFINIBAND_VIRT_DMA
select NET_UDP_TUNNEL
select CRYPTO
select CRYPTO_CRC32
select CRC32
help
This driver implements the InfiniBand RDMA transport over
the Linux network stack. It enables a system with a

3
drivers/infiniband/sw/rxe/rxe.c
View file

@ -31,9 +31,6 @@ void rxe_dealloc(struct ib_device *ib_dev)
WARN_ON(!RB_EMPTY_ROOT(&rxe->mcg_tree));
if (rxe->tfm)
crypto_free_shash(rxe->tfm);
mutex_destroy(&rxe->usdev_lock);
}

1
drivers/infiniband/sw/rxe/rxe.h
View file

@ -21,7 +21,6 @@
#include <rdma/ib_umem.h>
#include <rdma/ib_cache.h>
#include <rdma/ib_addr.h>
#include <crypto/hash.h>
#include "rxe_net.h"
#include "rxe_opcode.h"

40
drivers/infiniband/sw/rxe/rxe_icrc.c
View file

@ -9,28 +9,6 @@
#include "rxe.h"
#include "rxe_loc.h"
/**
* rxe_icrc_init() - Initialize crypto function for computing crc32
* @rxe: rdma_rxe device object
*
* Return: 0 on success else an error
*/
int rxe_icrc_init(struct rxe_dev *rxe)
{
struct crypto_shash *tfm;
tfm = crypto_alloc_shash("crc32", 0, 0);
if (IS_ERR(tfm)) {
rxe_dbg_dev(rxe, "failed to init crc32 algorithm err: %ld\n",
PTR_ERR(tfm));
return PTR_ERR(tfm);
}
rxe->tfm = tfm;
return 0;
}
/**
* rxe_crc32() - Compute cumulative crc32 for a contiguous segment
* @rxe: rdma_rxe device object
@ -42,23 +20,7 @@ int rxe_icrc_init(struct rxe_dev *rxe)
*/
static __be32 rxe_crc32(struct rxe_dev *rxe, __be32 crc, void *next, size_t len)
{
__be32 icrc;
int err;
SHASH_DESC_ON_STACK(shash, rxe->tfm);
shash->tfm = rxe->tfm;
*(__be32 *)shash_desc_ctx(shash) = crc;
err = crypto_shash_update(shash, next, len);
if (unlikely(err)) {
rxe_dbg_dev(rxe, "failed crc calculation, err: %d\n", err);
return (__force __be32)crc32_le((__force u32)crc, next, len);
}
icrc = *(__be32 *)shash_desc_ctx(shash);
barrier_data(shash_desc_ctx(shash));
return icrc;
return (__force __be32)crc32_le((__force u32)crc, next, len);
}
/**

1
drivers/infiniband/sw/rxe/rxe_loc.h
View file

@ -168,7 +168,6 @@ int rxe_sender(struct rxe_qp *qp);
int rxe_receiver(struct rxe_qp *qp);
/* rxe_icrc.c */
int rxe_icrc_init(struct rxe_dev *rxe);
int rxe_icrc_check(struct sk_buff *skb, struct rxe_pkt_info *pkt);
void rxe_icrc_generate(struct sk_buff *skb, struct rxe_pkt_info *pkt);

1
drivers/infiniband/sw/rxe/rxe_req.c
View file

@ -5,7 +5,6 @@
*/
#include <linux/skbuff.h>
#include <crypto/hash.h>
#include "rxe.h"
#include "rxe_loc.h"

4
drivers/infiniband/sw/rxe/rxe_verbs.c
View file

@ -1546,10 +1546,6 @@ int rxe_register_device(struct rxe_dev *rxe, const char *ibdev_name,
if (err)
return err;
err = rxe_icrc_init(rxe);
if (err)
return err;
err = ib_register_device(dev, ibdev_name, NULL);
if (err)
rxe_dbg_dev(rxe, "failed with error %d\n", err);

1
drivers/infiniband/sw/rxe/rxe_verbs.h
View file

@ -404,7 +404,6 @@ struct rxe_dev {
atomic64_t stats_counters[RXE_NUM_OF_COUNTERS];
struct rxe_port port;
struct crypto_shash *tfm;
};
static inline struct net_device *rxe_ib_device_get_netdev(struct ib_device *dev)