archives/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-03-08 03:24:45 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

mfd: macsmc: Remove error prints for devm_add_action_or_reset()

Browse source 
When `devm_add_action_or_reset()` fails, it is due to a failed memory
allocation and will thus return `-ENOMEM`. `dev_err_probe()` doesn't do
anything when error is `-ENOMEM`. Therefore, remove the useless call to
`dev_err_probe()` when `devm_add_action_or_reset()` fails, and just
return the value instead.

Signed-off-by: Waqar Hameed <waqar.hameed@axis.com>
Reviewed-by: Sven Peter <sven@kernel.org>
Link: https://lore.kernel.org/r/pnd8qjym7td.a.out@axis.com
Signed-off-by: Lee Jones <lee@kernel.org>
This commit is contained in:
Waqar Hameed 2025-08-05 11:33:34 +02:00 • committed by Lee Jones
parent 9ac4890ac3
commit 99767a0c8b
1 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
drivers/mfd/macsmc.c
View file

@ -429,7 +429,7 @@ static int apple_smc_probe(struct platform_device *pdev)
ret = devm_add_action_or_reset(dev, apple_smc_rtkit_shutdown, smc);
if (ret)
return dev_err_probe(dev, ret, "Failed to register rtkit shutdown action");
return ret;
ret = apple_rtkit_start_ep(smc->rtk, SMC_ENDPOINT);
if (ret)
@ -465,7 +465,7 @@ static int apple_smc_probe(struct platform_device *pdev)
apple_smc_write_flag(smc, SMC_KEY(NTAP), true);
ret = devm_add_action_or_reset(dev, apple_smc_disable_notifications, smc);
if (ret)
return dev_err_probe(dev, ret, "Failed to register notification disable action");
return ret;
ret = devm_mfd_add_devices(smc->dev, PLATFORM_DEVID_NONE,
apple_smc_devs, ARRAY_SIZE(apple_smc_devs),