archives/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-03-08 01:04:41 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

btrfs: update comment for delalloc flush and oe wait in btrfs_clone_files()

Browse source 
Make the comment more detailed about why we need to flush delalloc and
wait for ordered extent completion before attempting to invalidate the
page cache.

Reviewed-by: Qu Wenruo <wqu@suse.com>
Reviewed-by: Boris Burkov <boris@bur.io>
Signed-off-by: Filipe Manana <fdmanana@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
This commit is contained in:
Filipe Manana 2026-01-09 12:09:18 +00:00 • committed by David Sterba
parent ae23fee41b
commit 8ecf596ed8
1 changed files with 7 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

9
fs/btrfs/reflink.c
View file

@ -754,8 +754,13 @@ static noinline int btrfs_clone_files(struct file *file, struct file *file_src,
/*
* We may have copied an inline extent into a page of the destination
* range, so wait for writeback to complete before invalidating pages
* from the page cache. This is a rare case.
* range. So flush delalloc and wait for ordered extent completion.
* This is to ensure the invalidation below does not fail, as if for
* example it finds a dirty folio, our folio release callback
* (btrfs_release_folio()) returns false, which makes the invalidation
* return an -EBUSY error. We can't ignore such failures since they
* could come from some range other than the copied inline extent's
* destination range and we have no way to know that.
*/
ret = btrfs_wait_ordered_range(BTRFS_I(inode), destoff, len);
if (ret < 0)