archives/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-03-08 01:04:41 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

rust: macros: convert #[export] to use syn

Browse source 
This eliminates the custom `function_name` helper.

Reviewed-by: Tamir Duberstein <tamird@gmail.com>
Reviewed-by: Benno Lossin <lossin@kernel.org>
Signed-off-by: Gary Guo <gary@garyguo.net>
Link: https://patch.msgid.link/20260112170919.1888584-7-gary@kernel.org
Signed-off-by: Miguel Ojeda <ojeda@kernel.org>
This commit is contained in:
Gary Guo 2026-01-12 17:07:17 +00:00 • committed by Miguel Ojeda
parent 5f70457720
commit 8db9164b76
3 changed files with 12 additions and 35 deletions
Download patch file Download diff file Expand all files Collapse all files

24
rust/macros/export.rs
View file

@ -3,19 +3,14 @@
use proc_macro2::TokenStream;
use quote::quote;
use crate::helpers::function_name;
/// Please see [`crate::export`] for documentation.
pub(crate) fn export(_attr: TokenStream, ts: TokenStream) -> TokenStream {
let Some(name) = function_name(ts.clone()) else {
return "::core::compile_error!(\"The #[export] attribute must be used on a function.\");"
.parse::<TokenStream>()
.unwrap();
};
pub(crate) fn export(f: syn::ItemFn) -> TokenStream {
let name = &f.sig.ident;
// This verifies that the function has the same signature as the declaration generated by
// bindgen. It makes use of the fact that all branches of an if/else must have the same type.
let signature_check = quote!(
quote! {
// This verifies that the function has the same signature as the declaration generated by
// bindgen. It makes use of the fact that all branches of an if/else must have the same
// type.
const _: () = {
if true {
::kernel::bindings::#name
@ -23,9 +18,8 @@ pub(crate) fn export(_attr: TokenStream, ts: TokenStream) -> TokenStream {
#name
};
};
);
let no_mangle = quote!(#[no_mangle]);
TokenStream::from_iter([signature_check, no_mangle, ts])
#[no_mangle]
#f
}
}

18
rust/macros/helpers.rs
View file

@ -2,7 +2,6 @@
use proc_macro2::{
token_stream,
Ident,
TokenStream,
TokenTree, //
};
@ -50,23 +49,6 @@ impl AsciiLitStr {
}
}
/// Given a function declaration, finds the name of the function.
pub(crate) fn function_name(input: TokenStream) -> Option<Ident> {
let mut input = input.into_iter();
while let Some(token) = input.next() {
match token {
TokenTree::Ident(i) if i == "fn" => {
if let Some(TokenTree::Ident(i)) = input.next() {
return Some(i);
}
return None;
}
_ => continue,
}
}
None
}
pub(crate) fn file() -> String {
#[cfg(not(CONFIG_RUSTC_HAS_SPAN_FILE))]
{

5
rust/macros/lib.rs
View file

@ -234,8 +234,9 @@ pub fn vtable(attr: TokenStream, input: TokenStream) -> TokenStream {
/// This macro is *not* the same as the C macros `EXPORT_SYMBOL_*`. All Rust symbols are currently
/// automatically exported with `EXPORT_SYMBOL_GPL`.
#[proc_macro_attribute]
pub fn export(attr: TokenStream, ts: TokenStream) -> TokenStream {
export::export(attr.into(), ts.into()).into()
pub fn export(attr: TokenStream, input: TokenStream) -> TokenStream {
parse_macro_input!(attr as syn::parse::Nothing);
export::export(parse_macro_input!(input)).into()
}
/// Like [`core::format_args!`], but automatically wraps arguments in [`kernel::fmt::Adapter`].