archives/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-03-08 03:24:45 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

riscv: ptrace: return ENODATA for inactive vector extension

Browse source 
Currently, ptrace returns EINVAL when the vector extension is supported
but not yet activated for the traced process. This error code is not
always appropriate since the ptrace arguments may be valid.

Debug tools like gdbserver expect ENODATA when the requested register
set is not active, e.g. see [1]. This expectation seems to be more
appropriate, so modify the vector ptrace implementation to return:
- EINVAL when V extension is not supported
- ENODATA when V extension is supported but not active

[1] 637f25e886/gdbserver/linux-low.cc (L5020)

Signed-off-by: Ilya Mamay <mmamayka01@gmail.com>
Signed-off-by: Sergey Matyukevich <geomatsi@gmail.com>
Reviewed-by: Andy Chiu <andybnac@gmail.com>
Tested-by: Andy Chiu <andybnac@gmail.com>
Link: https://patch.msgid.link/20251214163537.1054292-2-geomatsi@gmail.com
Signed-off-by: Paul Walmsley <pjw@kernel.org>
This commit is contained in:
Ilya Mamay 2026-01-25 21:09:56 -07:00 • committed by Paul Walmsley
parent d30c1683aa
commit 8cdb04bd06
1 changed files with 8 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

10
arch/riscv/kernel/ptrace.c
View file

@ -99,9 +99,12 @@ static int riscv_vr_get(struct task_struct *target,
struct __riscv_v_ext_state *vstate = &target->thread.vstate;
struct __riscv_v_regset_state ptrace_vstate;
if (!riscv_v_vstate_query(task_pt_regs(target)))
if (!(has_vector() || has_xtheadvector()))
return -EINVAL;
if (!riscv_v_vstate_query(task_pt_regs(target)))
return -ENODATA;
/*
* Ensure the vector registers have been saved to the memory before
* copying them to membuf.
@ -134,9 +137,12 @@ static int riscv_vr_set(struct task_struct *target,
struct __riscv_v_ext_state *vstate = &target->thread.vstate;
struct __riscv_v_regset_state ptrace_vstate;
if (!riscv_v_vstate_query(task_pt_regs(target)))
if (!(has_vector() || has_xtheadvector()))
return -EINVAL;
if (!riscv_v_vstate_query(task_pt_regs(target)))
return -ENODATA;
/* Copy rest of the vstate except datap */
ret = user_regset_copyin(&pos, &count, &kbuf, &ubuf, &ptrace_vstate, 0,
sizeof(struct __riscv_v_regset_state));