archives/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-03-08 03:44:45 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

drm/amdgpu: validate user queue size constraints

Browse source 
Add validation to ensure user queue sizes meet hardware requirements:
- Size must be a power of two for efficient ring buffer wrapping
- Size must be at least AMDGPU_GPU_PAGE_SIZE to prevent undersized allocations

This prevents invalid configurations that could lead to GPU faults or
unexpected behavior.

Reviewed-by: Christian König <christian.koenig@amd.com>
Signed-off-by: Jesse Zhang <jesse.zhang@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
This commit is contained in:
Jesse.Zhang 2026-01-28 11:35:57 +08:00 • committed by Alex Deucher
parent ba205ac3d6
commit 8079b87c02
1 changed files with 11 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

11
drivers/gpu/drm/amd/amdgpu/amdgpu_userq.c
View file

@ -932,6 +932,17 @@ static int amdgpu_userq_input_args_validate(struct drm_device *dev,
drm_file_err(filp, "invalidate userq queue va or size\n");
return -EINVAL;
}
if (!is_power_of_2(args->in.queue_size)) {
drm_file_err(filp, "Queue size must be a power of 2\n");
return -EINVAL;
}
if (args->in.queue_size < AMDGPU_GPU_PAGE_SIZE) {
drm_file_err(filp, "Queue size smaller than AMDGPU_GPU_PAGE_SIZE\n");
return -EINVAL;
}
if (!args->in.wptr_va || !args->in.rptr_va) {
drm_file_err(filp, "invalidate userq queue rptr or wptr\n");
return -EINVAL;