mirror of
https://github.com/torvalds/linux.git
synced 2026-03-08 01:24:47 +01:00
sched_ext: Fix SCX_EFLAG_INITIALIZED being a no-op flag
SCX_EFLAG_INITIALIZED is the sole member of enum scx_exit_flags with no
explicit value, so the compiler assigns it 0. This makes the bitwise OR
in scx_ops_init() a no-op:
sch->exit_info->flags |= SCX_EFLAG_INITIALIZED; /* |= 0 */
As a result, BPF schedulers cannot distinguish whether ops.init()
completed successfully by inspecting exit_info->flags.
Assign the value 1LLU << 0 so the flag is actually set.
Fixes: f3aec2adce ("sched_ext: Add SCX_EFLAG_INITIALIZED to indicate successful ops.init()")
Signed-off-by: David Carlier <devnexen@gmail.com>
Signed-off-by: Tejun Heo <tj@kernel.org>
This commit is contained in:
parent
2a064262eb
commit
749989b2d9
1 changed files with 1 additions and 1 deletions
|
|
@ -74,7 +74,7 @@ enum scx_exit_flags {
|
|||
* info communication. The following flag indicates whether ops.init()
|
||||
* finished successfully.
|
||||
*/
|
||||
SCX_EFLAG_INITIALIZED,
|
||||
SCX_EFLAG_INITIALIZED = 1LLU << 0,
|
||||
};
|
||||
|
||||
/*
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue