archives/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-03-08 04:04:43 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

apparmor: fix boolean argument in apparmor_mmap_file

Browse source 
The previous value of GFP_ATOMIC is an int and not a bool, potentially
resulting in UB when being assigned to a bool. In addition, the mmap hook
is called outside of locks (i.e. in a non-atomic context), so we can pass
a fixed constant value of false instead to common_mmap.

Signed-off-by: Ryan Lee <ryan.lee@canonical.com>
Signed-off-by: John Johansen <john.johansen@canonical.com>
This commit is contained in:
Ryan Lee 2026-01-07 11:48:54 -08:00 • committed by John Johansen
parent 8d34e16f7f
commit 48d5268e91
1 changed files with 1 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
security/apparmor/lsm.c
View file

@ -584,7 +584,7 @@ static int common_mmap(const char *op, struct file *file, unsigned long prot,
static int apparmor_mmap_file(struct file *file, unsigned long reqprot,
unsigned long prot, unsigned long flags)
{
return common_mmap(OP_FMMAP, file, prot, flags, GFP_ATOMIC);
return common_mmap(OP_FMMAP, file, prot, flags, false);
}
static int apparmor_file_mprotect(struct vm_area_struct *vma,